Feature - Add paging to live tv channel guide#5418
Open
WizardOfYendor1 wants to merge 3 commits intojellyfin:masterfrom
Open
Feature - Add paging to live tv channel guide#5418WizardOfYendor1 wants to merge 3 commits intojellyfin:masterfrom
WizardOfYendor1 wants to merge 3 commits intojellyfin:masterfrom
Conversation
…ng pattern). Basically, de-duplicate code and have a shared source of truth. Save computed values for rows/viewport versus inline recalculation - given it's integer math, it's of dubious value. e,.g. getProgramRow() in customplaybackoverlayfragement computes this every call and doesn't seem to have any issues. Perhaps this change isn't worth it? But seems like the right thing to do.
…his SEEMS like the best fit for this and allows for one place for usage outside of the livetv context.
WizardOfYendor1
force-pushed
the
feature/livetvverticalguidepaging
branch
from
0c19e45 to
68cbd23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the LiveTV channel guide AND the guide "popup" overlay display, allow the user to page up and down through the guide using the fast forward and rewind buttons.
Not all devices/remotes will be able to utilize this.
Changes
Added key handlers (trying to cover all variants) for FF/RW in the guide screens. Need to "math" what was visible to the user to calculate the page size and use that to define a scroll port page window. Also covers the scenario of being full "left" in the guide on the channel column....i.e. you can page there.
If user has scrolled right, do not scroll left/right when paging.
Code assistance
LLM used to understand certain aspects of the guide/key handling architecture. Also code review and enhancements.
** Testing **
Tested in an android studio emulator, on fire cube device and on an nvidia shield device. All function as expected. Given this is new, extra rigor should be applied and considered.