Feature - Added optional selecting preferred audio transcode codec and enable/disable of any audio codec.#5419
Feature - Added optional selecting preferred audio transcode codec and enable/disable of any audio codec.#5419Ranft65 wants to merge 6 commits intojellyfin:masterfrom
Conversation
…ed playback preferences: 1) Prefer transcoding to Dolby Digital 2) Disable AAC support (force AAC transcode)
|
Nice work. The force AAC transcode is working, but I also have some files in Opus 5.1 which are not being transcoded. I have soundbar connected with HDMI ARC, so only supported surround formats are EAC3 (with Atmos), AC3 and DTS. |
…ed playback preferences: 1) Prefer transcoding to Dolby Digital 2) Optionally disable AAC, DTS, FLAC, MP3, OPUS, TRUEHD, and/or VORBIS (force transcode)
|
PR updated to disable (force transcode of) AAC, DTS, FLAC, MP3, OPUS, TRUEHD, and/or VORBIS codecs. |
|
Tested a little bit more with latest changes. Turning of subs, allows for direct play video with audio transcode, but not always. |
|
The only changes I made were related to the supported audio codec list. The changes should have no effect on the video processing except that forcing a transcode by the server will limit the video output to be as supported / prioritized by the server (I think). You should check how your playback settings are on the server for when transcodes are done. Check I initially tried to change the server code to do what I wanted but found the server code to be complicated to figure out so I started hacking at the client instead after seeing what andreasgerner (https://github.com/andreasgerner) had already done to the client. |
|
@nielsvanvelzen could this supercede #5025 ? |
…ed playback preferences: 1) Prefer transcoding to Dolby Digital AC3 2) Optionally enable/disable AAC, AAC_LATM, AC3, ALAC, DCA, DTS, EAC3, FLAC, MLP, MP2, MP3, OPUS, PCM, TRUEHD, and/or VORBIS (force transcode)
|
Added options to enable/enable the rest of the audio codecs. Unless issues are found, this should be the last submit. |
|
I'm going to update this to allow any codec to be the preferred audio codec. The version now set to draft can only make the AC3 codec the preferred codec (and allow any audio codec to be disabled). |
…ed playback preferences: 1) Prefer transcoding to Dolby Digital AC3 2) Optionally enable/disable AAC, AAC_LATM, AC3, ALAC, DCA, DTS, EAC3, FLAC, MLP, MP2, MP3, OPUS, PCM, TRUEHD, and/or VORBIS (force transcode)
…k preferences: 1) Optionally set preferred audio transcoding to AAC, AC3, and MP3 2) Optionally enable/disable any audio codec. Transcoding will occur for any disabled audio codec.
# Conflicts: # app/src/main/java/org/jellyfin/androidtv/util/profile/deviceProfile.kt
|
Updates completed. Commits are ready for review. These commits provide the following user options under advanced playback preferences:
|
These commits provide the following user options under advanced playback preferences:
Optionally set preferred audio transcoding to AAC, AC3, and MP3.
Optionally enable/disable any audio codec. Transcoding will occur for any disabled audio codec (if supported by the Jelly server).
Many clients have poor AAC support and only support stereo AAC. This PR allows surround sound AAC media files to provide surround sound output on devices that do not support AAC surround sound by forcing a transcode of AAC. This PR can do the same for the other audio codecs as well by forcing transcodes of them (if supported by the Jellyfin server).
The setting of the preferred audio codec for audio transcoding was limited to AAC, AC3, and MP3 since there were issues with the Jellyfin server audio transcoding of the other audio codecs. Unexpected or failure of audio output may occur if disabling of the audio codecs is done such to force the Jellyfin server audio transcode to anything other than AAC, AC3, or MP3,
This PR was inspired by the open PR #5025 by https://github.com/andreasgerner.
Issues
Fixes #2867, #2602, #2991, #2432 and possibly a lot of similar issues.
Rework for #3109.
Rework for some parts of #3110.