Conversation
|
This branch is fully unsuitable for release, and releasing it would currently add no value to the ecosystem. Qt6 does not give us anything in a world where 5.15.11 exists. The most reasonable way forward is to ride Qt5 until compat loses support. Within that time we should have built an OSC per #537 or the related Qt Bug will have been fixed. Then we can port to the native API and at that point we can discuss sunsetting the Qt5 build. Migrating now would be way beyond premature imho. |
|
This needs to be held until we either:
Notably the rendering pipeline is completely busted and we're using a UI cutout workaround to make it even slightly work that kills all overlay menus and trick play in the player. |
|
some of these other changes are very good @nvllsvm, do you intend to open a new pr with them? |
|
Would you please add these ubuntu packages to the list of required packages for building for QT6 in Readme.md? |
|
This would help with the message from https://flathub.org/apps/com.github.iwalton3.jellyfin-media-player |
|
@kenden |
|
Thanks @sevenrats I think this is actually described in this issue: flathub/com.github.iwalton3.jellyfin-media-player#41 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment has been minimized.
This comment has been minimized.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment has been minimized.
This comment has been minimized.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment has been minimized.
This comment has been minimized.
JMP depends on qtwebengine 5.X which is marked as insecure. There seems to be some work in the JMP repo to port things to Qt6, but so far there doesn't appear to be any official releases with that, despite the fact that Qt5 is EOL and being dropped from various distro's repos. I will drop the package for now. If they don't provide a release soon I'll have to see whether I want to allow the insecure package or use something else to watch stuff. Related issues and PRs: - NixOS/nixpkgs#437865 - jellyfin/jellyfin-desktop#282 - jellyfin/jellyfin-desktop#599 - jellyfin/jellyfin-desktop#844 Signed-off-by: Linda Siemons <linda@catbrained.dev>
|
Ahh yes the positioning workaround fix. I was never happy with it because it broke thumbnail previews and drop-down menus, hence I basically tabled this project and decided to wait until I was forced to revisit it due to Qt 5 being end of life. I consider a proper fix to be fix rendering with upstream (unlikely) or implement a completely custom player UI. The latter is a lot of work, and honestly may make sense to switch to a better technical baseline if we abandon the main reason we use the abomination of a rendering pipeline this uses as it would add things like proper HDR and Dolby vision support. (In other words, there's a reason the upstream Plex Media Player application passed it's sell by date and this is likely it.) In this way MPV Shim always had a better technical foundation but the player UI leaves a lot to be desired for normal users. (I did add trick play to that though, proving you can paper over a lot of UX issues with it with enough LUA scripts though.) |
Co-authored by: Izzie Walton <ian@iwalton.com> Co-authored by: Satadru Pramanik <satadru@gmail.com> Co-authored by: sevenrats <sevenrats@tutanota.com> Co-authored by: xB <65196493+xBiei@users.noreply.github.com> Co-authored by: zjeffer <4633209+zjeffer@users.noreply.github.com>
|
I've seen you working on this and I just wanna say thank you! Sadly I lack the skill to help. Thanks for doing this! |
| // MPV doesn't support secondary subtitles - no-op for compatibility | ||
| console.log('[MPV] setSecondarySubtitleStreamIndex not supported, ignoring index:', index); |
There was a problem hiding this comment.
It does seem to be supported: https://mpv.io/manual/master/#select-select-secondary-sid
10 participants
[removed]