Skip to content

Jellyfin 10.11 support#166

Merged
crobibero merged 3 commits into
masterfrom
unstable
Oct 20, 2025
Merged

Jellyfin 10.11 support#166
crobibero merged 3 commits into
masterfrom
unstable

Conversation

@crobibero
Copy link
Copy Markdown
Member

No description provided.

Comment thread Jellyfin.Plugin.OpenSubtitles/ClientSideRateLimiter.cs Dismissed
@crobibero crobibero merged commit a28c149 into master Oct 20, 2025
6 of 7 checks passed
@crobibero crobibero deleted the unstable branch October 20, 2025 01:06
@MBR-0001
Copy link
Copy Markdown
Member

@crobibero I've noticed that the missing subtitles task has become very slow, looking at the logs I see this:
image
it seems that after every 5 search requests there's a 5 second pause with Unable to acquire rate limit lease, waiting 00:00:05
is this expected behavior? before this PR the whole task would take maybe a minute and now it takes 6+ mins

I'm looking at the diff and I see that a lot of my old rate limiting code has been removed but I don't see the new code that's supposed to replace it. I have never heard of FixedWindowRateLimiter until now so it maybe does something internally, but the behavior I'm seeing tells me something isn't working correctly

@crobibero
Copy link
Copy Markdown
Member Author

OpenSubtitles has a rate limit per IP of 5 requests per second. It sounds like I may have set the limit incorrectly. I'll see if I can take a look today

https://opensubtitles.stoplight.io/docs/opensubtitles-api/6ef2e232095c7-best-practices#limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants