Skip to content

add filter options for missing images #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Viperinius wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add filter options for missing images #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Jellyfin.Plugin.Reports/Api/ReportRequests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,12 @@ protected BaseReportRequest()
// [ApiMember(Name = "HasTvdbId", Description = "Optional filter by items that have a tvdb id or not.", IsRequired = false, DataType = "bool", ParameterType = "query", Verb = "GET")]
public bool? HasTvdbId { get; set; }

// [ApiMember(Name = "HasImagePrimary", Description = "Optional filter by items that have a primary image or not.", IsRequired = false, DataType = "bool", ParameterType = "query", Verb = "GET")]
public bool? HasImagePrimary { get; set; }

// [ApiMember(Name = "HasImageBackdrop", Description = "Optional filter by items that have a backdrop image or not.", IsRequired = false, DataType = "bool", ParameterType = "query", Verb = "GET")]
public bool? HasImageBackdrop { get; set; }

// [ApiMember(Name = "IsInBoxSet", Description = "Optional filter by items that are in boxsets, or not.", IsRequired = false, DataType = "bool", ParameterType = "query", Verb = "GET")]
public bool? IsInBoxSet { get; set; }

Expand Down
8 changes: 8 additions & 0 deletions Jellyfin.Plugin.Reports/Api/ReportsController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ public ActionResult<ReportResult> GetItemReport(
[FromQuery] bool? hasImdbId,
[FromQuery] bool? hasTmdbId,
[FromQuery] bool? hasTvdbId,
[FromQuery] bool? hasImagePrimary,
[FromQuery] bool? hasImageBackdrop,
[FromQuery] bool? isInBoxSet,
[FromQuery] string? excludeItemIds,
[FromQuery] bool? enableTotalRecordCount,
Expand Down Expand Up @@ -179,6 +181,8 @@ public ActionResult<ReportResult> GetItemReport(
HasThemeVideo = hasThemeVideo,
HasTmdbId = hasTmdbId,
HasTvdbId = hasTvdbId,
HasImagePrimary = hasImagePrimary,
HasImageBackdrop = hasImageBackdrop,
ImageTypeLimit = imageTypeLimit,
IncludeItemTypes = includeItemTypes,
IsHD = isHd,
Expand Down Expand Up @@ -283,6 +287,8 @@ public async Task<ActionResult<ReportResult>> GetReportDownload(
[FromQuery] bool? hasImdbId,
[FromQuery] bool? hasTmdbId,
[FromQuery] bool? hasTvdbId,
[FromQuery] bool? hasImagePrimary,
[FromQuery] bool? hasImageBackdrop,
[FromQuery] bool? isInBoxSet,
[FromQuery] string? excludeItemIds,
[FromQuery] bool? enableTotalRecordCount,
Expand Down Expand Up @@ -404,6 +410,8 @@ public async Task<ActionResult<ReportResult>> GetReportDownload(
HasThemeVideo = hasThemeVideo,
HasTmdbId = hasTmdbId,
HasTvdbId = hasTvdbId,
HasImagePrimary = hasImagePrimary,
HasImageBackdrop = hasImageBackdrop,
ImageTypeLimit = imageTypeLimit,
IncludeItemTypes = includeItemTypes,
IsHD = isHd,
Expand Down
21 changes: 21 additions & 0 deletions Jellyfin.Plugin.Reports/Api/ReportsService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,27 @@ private ReportResult GetReportResult(BaseReportRequest request)
User user = !string.IsNullOrWhiteSpace(request.UserId) ? _userManager.GetUserById(new Guid(request.UserId)) : null;
ReportBuilder reportBuilder = new ReportBuilder(_libraryManager);
QueryResult<BaseItem> queryResult = GetQueryResult(request, user);

if (request.HasImagePrimary != null || request.HasImageBackdrop != null)
{
var tmpResults = new List<BaseItem>();
foreach (var result in queryResult.Items)
{
// filter for requested image type matches
if ( (request.HasImagePrimary?.Equals(result.HasImage(ImageType.Primary)) ?? true)
&& (request.HasImageBackdrop?.Equals(result.HasImage(ImageType.Backdrop)) ?? true))
{
tmpResults.Add(result);
}
}

queryResult = new QueryResult<BaseItem>
{
Items = tmpResults,
TotalRecordCount = tmpResults.Count,
};
}

ReportResult reportResult = reportBuilder.GetResult(queryResult.Items, request);
reportResult.TotalRecordCount = queryResult.TotalRecordCount;

Expand Down
6 changes: 6 additions & 0 deletions Jellyfin.Plugin.Reports/Web/reports.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,12 @@ <h2>Management</h2>
<input class="chkMissingTvdbId" type="checkbox" name="chkMissingTvdbId" id="chkMissingTvdbId">
<label for="chkMissingTvdbId">Missing Tvdb id</label>
<br />
<input class="chkMissingImagePrimary" type="checkbox" name="chkMissingImagePrimary" id="chkMissingImagePrimary">
<label for="chkMissingImagePrimary">Missing Primary Image</label>
<br />
<input class="chkMissingImageBackdrop" type="checkbox" name="chkMissingImageBackdrop" id="chkMissingImageBackdrop">
<label for="chkMissingImageBackdrop">Missing Backdrop Image</label>
<br />
</div>
</div>
<div data-role="collapsible" data-collapsed="true" data-mini="true" id="GroupStatus">
Expand Down
18 changes: 18 additions & 0 deletions Jellyfin.Plugin.Reports/Web/reports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,8 @@ function updateFilterControls(context) {
context.querySelector('#chkMissingImdbId').checked = query.HasImdbId == false;
context.querySelector('#chkMissingTmdbId').checked = query.HasTmdbId == false;
context.querySelector('#chkMissingTvdbId').checked = query.HasTvdbId == false;
context.querySelector('#chkMissingImagePrimary').checked = query.HasImagePrimary == false;
context.querySelector('#chkMissingImageBackdrop').checked = query.HasImageBackdrop == false;

//Episodes
context.querySelector('#chkSpecialEpisode').checked = query.ParentIndexNumber == 0;
Expand Down Expand Up @@ -950,6 +952,22 @@ export default function (view) {
reloadItems(view);
});

const chkMissingImagePrimary = view.querySelector('#chkMissingImagePrimary');
chkMissingImagePrimary.addEventListener('change', () => {
query.StartIndex = 0;
query.HasImagePrimary = chkMissingImagePrimary.checked ? false : null;

reloadItems(view);
});

const chkMissingImageBackdrop = view.querySelector('#chkMissingImageBackdrop');
chkMissingImageBackdrop.addEventListener('change', () => {
query.StartIndex = 0;
query.HasImageBackdrop = chkMissingImageBackdrop.checked ? false : null;

reloadItems(view);
});

//Episodes
const chkMissingEpisode = view.querySelector('#chkMissingEpisode');
chkMissingEpisode.addEventListener('change', () => {
Expand Down