Stop playback and return home on CEC active source loss#830
Stop playback and return home on CEC active source loss#830Kaluzny-IT wants to merge 3 commits intojellyfin:masterfrom
Conversation
|
Update the Whats New if you'd like credit for your work. |
1hitsong
left a comment
There was a problem hiding this comment.
This needs to be a user setting defaulted to disabled.
My wife frequently plays audio over headphones when she sleeps. She plays something then turns the TV off. My understanding of the CEC event is when she turns the TV off, playback will stop. Which means users will have lost an ability by implementing this as-is.
| end if | ||
|
|
||
| ' Stop audio playback if active | ||
| if m.global.audioPlayer.state = "playing" or m.global.audioPlayer.state = "paused" |
There was a problem hiding this comment.
| if m.global.audioPlayer.state = "playing" or m.global.audioPlayer.state = "paused" | |
| if isStringEqual(m.global.audioPlayer.state, MediaPlaybackState.PLAYING) or isStringEqual(m.global.audioPlayer.state, MediaPlaybackState.PAUSED) |
Do separate video and audio settings make sense? Stopping video when the TV turns off seems reasonable. Not stopping audio by default would address the use case you’re describing. The new code is already checking the playback type so I don’t think separate config for each would be much more work. That being said, I don’t have any Rokus that would benefit from CEC so not a major concern for me either way. |
|
Separate A/V settings feels like overkill for a 1st pass to me. Perhaps we go with 1 for the start and if peeps ask for it we could separate. |
Changes
Issues