Fix non-square trickplay thumbnail rendering and seek buffering overlay.#859
Open
VX-101 wants to merge 1 commit intojellyfin:masterfrom
Open
Fix non-square trickplay thumbnail rendering and seek buffering overlay.#859VX-101 wants to merge 1 commit intojellyfin:masterfrom
VX-101 wants to merge 1 commit intojellyfin:masterfrom
Conversation
Author
|
Extra testing was performed with a local Test file https://drive.google.com/drive/folders/1pFmQgKSTjza6vTE6vyEZYNWXZRBQROe7?usp=drive_link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes trickplay thumbnail rendering for non-square tile images and improves the seek buffering transition.
TileWidthPosternodes without dropping the current preview updateDetails
Jellyfin reports
TileWidthas the number of thumbnails per row andTileHeightas the number of thumbnails per column. The Roku client was usingTileHeightwhen calculating the thumbnail row inside a trickplay tile image. That works for square layouts like10x10, but is wrong for non-square layouts.The preload calculation could also request one tile image beyond the valid range when the thumbnail count exactly filled a tile image.
The preview node update now continues after creating or recreating a
Posternode, so the current preview update still applies URI, size, clipping, translation, and visibility.The seek path now starts the existing buffering overlay before applying the seek. The buffering state handler also starts the overlay so the player does not show a blank screen while playback resumes.
Testing
npm run buildsuccessfully.5x10trickplay test clip with visible thumbnail markers5x10trickplay images