Skip to content

Fix skip button positioning & design #6670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

viown
Copy link
Member

@viown viown commented Mar 27, 2025

Screenshots here

Changes
Fixes the positioning and styling of the skip button

Issues

@viown viown added the enhancement Improve existing functionality or small fixes label Mar 27, 2025
@viown viown requested a review from a team as a code owner March 27, 2025 13:07
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Mar 27, 2025

Cloudflare Pages deployment

Latest commit 6329e27
Status ✅ Deployed!
Preview URL https://c6fa7157.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@dmitrylyzo
Copy link
Contributor

I added skip-button-container in #6510 - will conflict. I think we can fix the design in the release branch as well.

@viown
Copy link
Member Author

viown commented Apr 2, 2025

The question is do we plan to do another point release? I figure I'll just wait until the changes are backported and rebase 👍.

@thornbill
Copy link
Member

I have backported the changes. There is a chance we will still do another 10.10 release but nothing for certain.

@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Apr 2, 2025
@jellyfin-bot
Copy link
Collaborator

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@jellyfin-bot jellyfin-bot added the stale No activity for an extended length of time label Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes merge conflict Conflicts prevent merging stale No activity for an extended length of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants