Add public user listing option to networking settings #6672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dmitrylyzo
reviewed
Mar 27, 2025
dmitrylyzo
reviewed
Apr 6, 2025
Comment on lines
149
to
155
| if (config.PublicUserListingLocalOnly && config.PublicUserListing) { | ||
| page.querySelector('#selectPublicUserListing').value = 'local'; | ||
| } else if (config.PublicUserListing) { | ||
| page.querySelector('#selectPublicUserListing').value = 'always'; | ||
| } else { | ||
| page.querySelector('#selectPublicUserListing').value = 'never'; | ||
| } |
There was a problem hiding this comment.
For maintainability: fewer places with the identifier.
Suggested change
| if (config.PublicUserListingLocalOnly && config.PublicUserListing) { | |
| page.querySelector('#selectPublicUserListing').value = 'local'; | |
| } else if (config.PublicUserListing) { | |
| page.querySelector('#selectPublicUserListing').value = 'always'; | |
| } else { | |
| page.querySelector('#selectPublicUserListing').value = 'never'; | |
| } | |
| const selectPublicUserListing = page.querySelector('#selectPublicUserListing'); | |
| if (config.PublicUserListingLocalOnly && config.PublicUserListing) { | |
| selectPublicUserListing.value = 'local'; | |
| } else if (config.PublicUserListing) { | |
| selectPublicUserListing.value = 'always'; | |
| } else { | |
| selectPublicUserListing.value = 'never'; | |
| } |
There was a problem hiding this comment.
that should be done, thanks for the feedback!
dmitrylyzo
reviewed
Apr 6, 2025
| @@ -46,6 +46,8 @@ function onSubmit(e) { | |||
| return s.length > 0; | |||
| }); | |||
|
|
|||
| const publicUserListing = form.querySelector('#selectPublicUserListing'); | |||
There was a problem hiding this comment.
I think .value was fine.
Otherwise, it would be better to rename publicUserListing to selectPublicUserListing to match the other function. Or vice versa.
There was a problem hiding this comment.
Great, renamed the variable and extra spacing added
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add public user listing option to networking settings
This is to provide web client control of the feature added in jellyfin/jellyfin#13776