Update server update required handling #6796
Merged
+65
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
nielsvanvelzen
approved these changes
Apr 23, 2025
thornbill
force-pushed
the
update-server-page
branch
from
c4ab3d8 to
3b1ed1a
Compare
|
thornbill
changed the title
|
Ok I updated this to remove the dedicated route. Redirecting to/from the dedicated route when the connection state changed was overly complicated. Instead just rendering the error state in the current route context seems like a better approach. A future PR will update handling for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issues
N/A