Add removal of items in multi-selection for collections #6800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: Implement Remove from collections for multiselect in the collections screen. (issue jellyfin#6772) Issues: N/A
Cloudflare Pages deployment
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
viown
reviewed
Apr 24, 2025
viown
reviewed
Apr 24, 2025
Co-authored-by: viown <[email protected]>
|
viown
requested changes
Apr 27, 2025
There was a problem hiding this comment.
It looks like you have a race condition in your code that can sometimes prevent the "Remove from collection" menu item from showing.
If this promise resolves before this promise, collectionItem will be null and the menu item will not be added.
Instead, you'll need to re-structure your promises to follow an A -> B -> C structure. You can refactor your collection fetch call:
const collectionPromise = collectionId ? apiClient.getItem(user.Id, collectionId) : Promise.resolve(null)Then wrap the previous promise with:
collectionPromise.then(collectionItem => {
...
})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Implement Remove from collections for multiselect in the collections screen. (issue #6772)
Issues:
N/A