Implemented continuous checking of the behavior of track control buttons in a playlist

[JustChickNugget]

Closes #7432

Now track control buttons will disappear when the user reaches last track watching the playlist.

Changes
The behavior of track control buttons is checked each time a track is switched (pressing on the Previous track, Next track buttons via interface or using keyboard shortcuts).

Issues
#7432

[jellyfin-bot]

Cloudflare Pages deployment

Latest commit	06d3145
Status	✅ Deployed!
Preview URL	https://cfbc6072.jellyfin-web.pages.dev
Type	🔀 Preview

View build logs

[tylers-username]

@thornbill, this MR performs as described for movies and tv shows — resolving the case described in #7433

When tested against the current functionality, music playlists continue to work as expected in all modes (shuffle, repeat, no-repeat, no-shuffle).

⚠️ Current functionality enables users to go back once they arrive at the end of a movie or tv show playlist. That is no longer possible in this MR as the playlist controls are removed at the end of the playlists, meaning no back button is available.

[JustChickNugget]

@thornbill, this MR performs as described for movies and tv shows — resolving the case described in #7433

When tested against the current functionality, music playlists continue to work as expected in all modes (shuffle, repeat, no-repeat, no-shuffle).

⚠️ Current functionality enables users to go back once they arrive at the end of a movie or tv show playlist. That is no longer possible in this MR as the playlist controls are removed at the end of the playlists, meaning no back button is available.

I was planning to leave it as it was before, but I get your point.

[tylers-username]

@thornbill, this MR performs as described for movies and tv shows — resolving the case described in #7433
When tested against the current functionality, music playlists continue to work as expected in all modes (shuffle, repeat, no-repeat, no-shuffle).
⚠️ Current functionality enables users to go back once they arrive at the end of a movie or tv show playlist. That is no longer possible in this MR as the playlist controls are removed at the end of the playlists, meaning no back button is available.

I was planning to leave it as it was before, but I get your point.

Yeah, the "⚠️" was to call attention to it—unsure if it was actually right or wrong.

Your latest commit seems to handle this nicely, though. 👍

[dmitrylyzo]

Tbf, I am not sure if hiding the buttons is a good idea ("jumping buttons"), so I reviewed the PR mainly from a technical point of view. Simply disabling the buttons may be a better choice - need more opinions.

[dmitrylyzo]

currentPlaylistIndex === currentPlaylistIndex is always true. 🤔

I believe you need to check currentVisibleMenu === 'osd' to keep the OSD hidden (imo, updateTrackButtonsState should not show the OSD).

Suggested change

	if (currentPlaylist.length === 1 || currentPlaylistIndex === currentPlaylistIndex) {
	if (currentVisibleMenu === 'osd') {

[JustChickNugget]

Whoops, what a stupid mistake. Had a hard day, sorry

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[JustChickNugget]

Tbf, I am not sure if hiding the buttons is a good idea ("jumping buttons"), so I reviewed the PR mainly from a technical point of view. Simply disabling the buttons may be a better choice - need more opinions.

As I mentioned earlier, users may be confused about having different behaviors in two situations described in the issue #7432. This pull request actually addresses more details than the issue describes at the moment, giving a better UX (in my opinion) for controlling the current track on the playback, removing the "Previous track" button at the first track of the playlist, and removing the "Next track" button at the last track of the playlist.

Why? Because as a Jellyfin user, I counted the original behavior confusing, so I thought about making it a little bit better.