Update ASS subtitles immediately when adjusting subtitle offset #7440
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Cloudflare Pages deployment
|
Contributor
|
I think it's better to fix the "cache stalling" in https://github.com/jellyfin/JavascriptSubtitlesOctopus (jellyfin/JavascriptSubtitlesOctopus#68). |
Author
|
Sounds good, if that fixes the issue. I'll put this as a draft for now and see what happens with your PR. |
abitofevrything
force-pushed
the
feat/live-update-subtitles
branch
from
7390a54 to
b765cb5
Compare
|
Author
|
Reopened without the workaround for the underlying issue that has been fixed in the subtitle renderer itself. The dependency will need to be bumped when it releases. The other change about updating the subtitle offset as the scrollbar is being moved is still a valid change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes an issue where the ASS renderer would not render subtitles when adjusting the offset backwards due to frames for a position further forward being cached.
This PR also makes it so that subtitles update as the subtitle offset scroller is being moved, instead of only when it is released. This is slightly more convenient for setting the offset as desired.
Issues
Fixes #7439