Convert nextUpSection from class to ID for consistency and theming #7453
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I decided to make this change because nothing was being assigned to the nextUpSection class, and it makes more sense for this class to be considered an ID, thus providing a greater level of customization if someone like me is creating their own theme. Another factor that led me to this change is the fact that the seasons section has an ID, but the next episodes section does not.
Collaborator
Cloudflare Pages deployment
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Nothing was ever assigned to the nextUpSection class, making it ineffective and harder to style in custom themes. Switching it to an ID enables meaningful selection and improves customization flexibility for theme authors. This also aligns the next episodes section with the seasons section, which already uses an ID.