Skip to content

make install instructions nicer #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 19, 2025

Conversation

felix920506
Copy link
Member

Trying to implement some ideas from jellyfin/jellyfin-meta#92
Open to feedback and/or major changes

@felix920506 felix920506 changed the title make windows instructions nicer make install instructions nicer Apr 15, 2025
Copy link
Member

@joshuaboniface joshuaboniface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two thoughts.

@felix920506 felix920506 marked this pull request as ready for review April 16, 2025 02:24
@jhparker88
Copy link

As a first time user (or even occasional installer) you would expect a list of OS's from where you start (as most software installation divide there instructions by OS) but now you have a single page dedicated to automatic installations mixing (which means scrolling until you find your OS) all OS information merged into one page (for users that might never us Linux or Windows or macOS). I would recommend to keep Linux, Windows, macOS separated by there dedicated pages to reduce the need for searching relevant information on a specific OS.

@joshuaboniface
Copy link
Member

I do agree wiht @jhparker88 that the flow/list should be a little nicer starting with broad OS categories. But also this derives from a discussion regarding what we want to support at 1st party vs. 3rd party so perhaps that's better left for another PR.

@felix920506
Copy link
Member Author

felix920506 commented Apr 16, 2025

@joshuaboniface I separated it out into the broad OS categories for the automatic installers. For the portable ones ¯_(ツ)_/¯

@jhparker88
Copy link

I would suggest moving the TrueNAS SCALE into the "Advanced" section given that it is similar to Synology and avoids cluttering the installation section.

@felix920506
Copy link
Member Author

@jhparker88 the reason Truenas scale isn't in advanced but Synology is that Synology users are actively causing support problems for us especially for hardware acceleration related problems since they use a kernel version so old even Intel doesn't support drivers for anymore. On top of that because they are such potatoes in terms of processing power, they are just a pain to support.

Truenas doesn't have this problem.

@jhparker88
Copy link

for us especially for hardware acceleration related problems since they use a kernel version so old even Intel doesn't support drivers for anymore. On top of that because they are such potatoes in terms of processing power, they are just a pain to support.

Well, I saw that more under the premise of "user" reach which means most users (not having any numbers here) will choose from the four main (Linux, Windows, macOS, or Container) and any specialized installations can be found in Advanced. I was also under the impression that advanced means doing more than just pulling a container or download a file and press enter. For example, I would love to see a Promox section next to the Synonlogy and TrueNAS to incorporate #1328 into it but I'm digressing here.

@felix920506 felix920506 force-pushed the rework-install-instructions branch from dd535e3 to 239182e Compare April 18, 2025 05:33
@felix920506 felix920506 mentioned this pull request Apr 19, 2025
53 tasks
@felix920506 felix920506 enabled auto-merge (squash) April 19, 2025 01:06
@felix920506 felix920506 merged commit c5dfaa5 into jellyfin:master Apr 19, 2025
8 checks passed
@felix920506 felix920506 deleted the rework-install-instructions branch April 19, 2025 01:08
@jellyfin-bot
Copy link

Cloudflare Pages deployment

Latest commit cd936ba10860bc8c3783fcf7b60a873ab7c1f16e
Status ✅ Deployed!
Preview URL https://324af247.jellyfin-org.pages.dev
Type 🔀 Preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants