-
-
Notifications
You must be signed in to change notification settings - Fork 428
Update container.md #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update container.md #1392
Conversation
Added lines for HTTPS and autodiscovery ports.
Cloudflare Pages deployment
|
@@ -173,6 +173,9 @@ Steps to run Jellyfin using Podman are similar to the Docker steps. | |||
--label "io.containers.autoupdate=registry" \ | |||
--name myjellyfin \ | |||
--publish 8096:8096/tcp \ | |||
--publish 8920:8920/tcp \ | |||
--publish 1900:1900/udp \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for DLNA to work, host networking is required, which makes forwarding port 1900 redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instructions provide two different examples of how to start a container. The first using a docker compose file does include the host option but the second one does not. It specifically only maps 8096 which seems to block everything else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As seen here:
serveradmin@jellyfin:~/podman/jellyfin$ podman run -d -p 8096:8096/tcp -u
852e320cdf4e897c1072f0d29bb6b3b817bb6c92562bd7eb05be644097d3c79d
serveradmin@jellyfin:~/podman/jellyfin$ podman port jellyfin
8096/tcp -> 0.0.0.0:8096
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to have host networking be the default, since some features require it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docker section uses host mode in the listed example command for reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current "podman run" example does not use host mode thus the need to open the autodiscovery ports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.podman.io/en/stable/markdown/podman-run.1.html
"host: Do not create a network namespace, the container uses the host’s network. Note: The host mode gives the container full access to local system services such as D-bus and is therefore considered insecure."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnwblue
The new seperated DLNA Plugin Documentation includes a warning that Docker will have to run in host mode for it to work,
No other services - appart from UPnP Port forwarding - make use of port 1900.
Maybe ad a smoll note that users who want to use the DLNA Plugin will have to use host-networking.
That way this hole topic can be solved easily.
Forwarding port 1900 to the docker-container is defenetly pointless though, as the required multicast messages will not be abled to reach the docker subnet regardless. So that should be removed regardless.
Kind regards 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think UPnP port forwarding needs that port and it got removed from the server anyways
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felix920506 If UPnP port forwarding uses any sort of discovery (which I would assume, so that it finds the Router and can communicate about what Ports to open. I could be wrong though.
Anyways, even better. And confirms my original point then 👌
Added lines for HTTPS and autodiscovery ports.