Fix precondition error responses to return correct status codes #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When PUT requests failed due to precondition errors (e.g., invalid calendar data), the server was returning 207 Multi-Status responses instead of the appropriate status code (e.g., 412 Precondition Failed). This caused Thunderbird to fail when importing ICS files. The issue was in Status.get_single_body() which raised NeedsMultiStatus whenever an error element was present. Now error elements are properly serialized into the response body as XML while preserving the original status code, per RFC 4918. Fixes #545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When PUT requests failed due to precondition errors (e.g., invalid calendar data), the server was returning 207 Multi-Status responses instead of the appropriate status code (e.g., 412 Precondition Failed). This caused Thunderbird to fail when importing ICS files.
The issue was in Status.get_single_body() which raised NeedsMultiStatus whenever an error element was present. Now error elements are properly serialized into the response body as XML while preserving the original status code, per RFC 4918.
Fixes #545