Improve compliance #553
Merged
Improve compliance #553
+58
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The param-filter functionality is fully implemented via the apply_param_filter() function. The parse_prop_filter() function delegates param-filter handling to the query execution phase, which is the correct design.
- UTF-8 encoding in CalDAV/CardDAV is required by RFC 5545/6350, not "hardcoded" - decode() already raises UnicodeDecodeError on invalid UTF-8, no need for additional character stripping - expand-property reporter already resolves property names via get_property_from_name() - Keeping unresolved hrefs is intentional behavior to allow clients to see what was referenced
RFC 4791 Section 7.9 (CalDAV calendar-multiget) and RFC 6352 Section 8.7 (CardDAV addressbook-multiget) require that multiget REPORT operations use Depth: 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.