Open
Conversation
- macOS: display ⌘ + K - Windows/Linux: display Ctrl + K - Mobile (Android/iOS): hide shortcut hint entirely - No changes to keyboard event handling logic
Member
|
Works on my IPhone, but I don't have an iPad or Android phone to test. Have you test your PR out on these latter devices @yats0x7? |
Contributor
Author
|
@krisstern Yep, sir, as of my testing it's working perfectly fine on both. iPad: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #524
as discussed between me and @krisstern on Gitter so it matches the requirement
This PR updates the search placeholder behavior to improve UX on mobile devices.
Changes
On mobile devices:
Placeholder now displays:
Search contributors...On desktop platforms (unchanged behavior):