Skip to content

feat(nginx-website): hide nginx version on error pages #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lemeurherve merged 3 commits into from
Jan 26, 2026
Merged

feat(nginx-website): hide nginx version on error pages #1869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94ac91b
feat(nginx-website): hide nginx version on error pages
lemeurherve Jan 26, 2026
76ab584
update chart version
lemeurherve Jan 26, 2026
348b0da
tests
lemeurherve Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/nginx-website/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ name: nginx-website
maintainers:
- email: jenkins-infra-team@googlegroups.com
name: jenkins-infra-team
version: 0.6.1
version: 0.7.0
5 changes: 3 additions & 2 deletions charts/nginx-website/templates/nginx-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ data:
{{ .Values.nginx.httpDirectives | indent 4 }}
{{ end }}
server {
listen {{ .Values.service.port }};
server_name {{ .Values.nginx.serverName }};
listen {{ .Values.service.port }};
server_name {{ .Values.nginx.serverName }};
server_tokens off;
{{- if .Values.nginx.overrideLocations }}
{{ .Values.nginx.overrideLocations | indent 6 }}
{{- else }}
Expand Down
5 changes: 4 additions & 1 deletion charts/nginx-website/tests/custom_values_locations_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ tests:
value: RELEASE-NAME-nginx-website
- matchRegex:
path: data["default.conf"]
pattern: 'listen 8080;'
pattern: 'listen 8080;'
- matchRegex:
path: data["default.conf"]
pattern: 'server_tokens off;'
- matchRegex:
path: data["default.conf"]
pattern: 'location /starwars'
5 changes: 4 additions & 1 deletion charts/nginx-website/tests/custom_values_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ tests:
pattern: '# default.conf'
- matchRegex:
path: data["default.conf"]
pattern: 'listen 8080;'
pattern: 'listen 8080;'
- matchRegex:
path: data["default.conf"]
pattern: 'server_tokens off;'
- matchRegex:
path: data["default.conf"]
pattern: 'root /custom;'
Expand Down
7 changes: 5 additions & 2 deletions charts/nginx-website/tests/defaults_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,13 @@ tests:
pattern: '# default.conf'
- matchRegex:
path: data["default.conf"]
pattern: 'listen 80;'
pattern: 'listen 80;'
- matchRegex:
path: data["default.conf"]
pattern: 'server_name localhost;'
pattern: 'server_name localhost;'
- matchRegex:
path: data["default.conf"]
pattern: 'server_tokens off;'
- matchRegex:
path: data["default.conf"]
pattern: 'root /usr/share/nginx/html;'
Expand Down