feat(ci.jenkins.io): remove docker json conf for (Azure) windows agents #4193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry picking the change from #3998 where it was only done for EC2 agents.
Comment on lines
449
to
450
|
|
||
| # Restart docker engine |
There was a problem hiding this comment.
Suggested change
| # Restart docker engine |
If no restart is needed, this comment can be removed.
dduportal
commented
Jun 17, 2025
| '@ | Set-Content C:\ProgramData\Docker\config\daemon.json | ||
|
|
||
| # Restart docker engine | ||
| Restart-Service docker |
Contributor
Author
There was a problem hiding this comment.
Damn, I messed up this line (unrelated to the PR: I did a PEBKAC in the GitHub UI). Gotta restore it.
There was a problem hiding this comment.
That's what my suggestion above was about. Since I wasn't sure if you removed it by error or not, I just suggested removing the associated comment if it was voluntary.
dduportal
added a commit
that referenced
this pull request
Jun 17, 2025
dduportal
added a commit
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking the change from #3998 where it was only done for EC2 agents.
Ref. https://matrix.to/#/!CXfiHlEKGLXlkMPLEN:gitter.im/$JYn3wdWAoAhTiWb4QiuXHLp0IJOP53lSmhQzob2PPTU?via=gitter.im&via=matrix.org&via=nani.wtf
It aims at fixing this kind of errors during Windows container builds:
(from jenkinsci/docker-agents#962 logs)