Only consider dependency bot pull request that are over 90days old#652
Merged
Conversation
when didn't fail locally consistently, but always fails with CI
alecharp
reviewed
May 5, 2025
alecharp
left a comment
Collaborator
There was a problem hiding this comment.
I do also have a problem locally running the tests. As discussed, I believed it's because of concurrent access of the method getCreateAt() which is a bridged method.
I'm investigating.
alecharp
requested changes
May 6, 2025
alecharp
left a comment
Collaborator
There was a problem hiding this comment.
I found out that the doReturn|when pattern is for spies, true but here it is used for mocks.
As for the WithBridgeMethod, it introduces a method for binary compatibility but it does not make the annotated method use the generated method.
Using
when(pr.getCreatedAt()).thenReturn(someDaysAgo);
should be working without any problem.
Collaborator
Author
|
I'm confused why you think that |
yes, I don't like this, but let's see if it passes CI
alecharp
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #651.
When you take a closer look, you'll see we are checking against the start of day 90 days ago. However, the tests aren't getting that close. I'm just checking for 91 days. I'm going to think about a few more tests, but this covers what I think we are looking for.
Testing done
mvn clean verifySubmitter checklist
feature/for new feature, or improvements ; Usingfix/for bug fixes ; Usingdocs/for any documentation changes.