Skip to content

Conversation

@tomhobson
Copy link

@tomhobson tomhobson commented Jun 5, 2023

Removing backwards compatability, as we'll promote this change with the ESO migration

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tomhobson
Copy link
Author

/cc @msvticket

@jenkins-x-bot jenkins-x-bot requested a review from msvticket April 5, 2024 11:09
@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Skisocks
To complete the pull request process, please assign tomhobson
You can assign the PR to them by writing /assign @tomhobson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msvticket
Copy link
Contributor

I'll have a first look now and will continue next week.

I'll begin with firing a question: How have you tested this so far?

Copy link
Contributor

@msvticket msvticket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msvticket
Copy link
Contributor

To get the schema right it might be easiest to import github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1 and use the structures defined in https://github.com/external-secrets/external-secrets/blob/main/apis/externalsecrets/v1beta1/externalsecret_types.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants