fix: overwrite existing environment variable #8898
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appending an environment variable doesn't do anything if it is already set
The problem
If the BINARY_NAME environment variable happens to be set the help text are messed up:
As compared to the correct:
This PR fixes that:
TOP_LEVEL_COMMAND has basically the same function as BINARY_NAME; some plugins use one and some the other.