Skip to content

fix: enable tls tests by default #3220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ankitm123 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: enable tls tests by default #3220

ankitm123 wants to merge 1 commit into from

Conversation

@ankitm123
Copy link
Member

@ankitm123 ankitm123 commented Jul 3, 2022

Signed-off-by: ankitm123 [email protected]

@jenkins-x-bot
Copy link
Contributor

jenkins-x-bot commented Jul 3, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ankitm123
You can assign the PR to them by writing /assign @ankitm123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ankitm123
Copy link
Member Author

ankitm123 commented Jul 4, 2022

/hold

ankitm123
ankitm123 commented Jul 4, 2022
View reviewed changes
.lighthouse/jenkins-x/triggers.yaml
- name: gsm
context: "gsm"
always_run: true
always_run: false
Copy link
Member Author

@ankitm123 ankitm123 Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will enable after tls tests pass

@ankitm123 ankitm123 force-pushed the enable-tls-tests branch 3 times, most recently from 1ace98c to d63bb7c Compare July 4, 2022 05:25
@ankitm123
Copy link
Member Author

ankitm123 commented Jul 4, 2022

/test tls

@jenkins-x-bot
Copy link
Contributor

jenkins-x-bot commented Jul 4, 2022

@ankitm123: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
tls c601c6c link /test tls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/hold size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ankitm123 @jenkins-x-bot