Skip to content

Conversation

@GavinPJK
Copy link
Contributor

@GavinPJK GavinPJK commented Dec 8, 2025

Changes

  • Add OCI registry authentication to Docker configuration secret schema
  • Include JX_REPOSITORY_USERNAME and JX_REPOSITORY_PASSWORD credentials in .dockerconfigjson when using OCI chart repositories

Context

Helm CLI does not use credHelpers within docker config for authentication (helm/helm#13228) but does support auth, with an encoded username and password.

when chartKind: true, let's use JX_REPOSITORY_USERNAME and JX_REPOSITORY_PASSWORD from the jx-boot-job-env-vars secret to generate an auth entry so helm can authenticate.

@jenkins-x-bot
Copy link
Contributor

Hi @GavinPJK. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign garethjevans
You can assign the PR to them by writing /assign @garethjevans in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msvticket
Copy link
Member

/ok-to-test

@GavinPJK
Copy link
Contributor Author

GavinPJK commented Dec 9, 2025

/retest

@GavinPJK
Copy link
Contributor Author

GavinPJK commented Dec 9, 2025

/test gsm

@GavinPJK
Copy link
Contributor Author

/retest

@jenkins-x-bot
Copy link
Contributor

@GavinPJK: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
gsm fbb51b1 link /test gsm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants