Rehydrate components with thisObject pointing to the script by Willem1987 · Pull Request #304 · jenkinsci/JenkinsPipelineUnit

Willem1987 · 2020-10-01T19:29:21Z

Attempt to fix #303

src/test/groovy/com/lesfurets/jenkins/unit/declarative/TestDeclarativePipeline.groovy

Willem1987 · 2020-10-10T18:44:40Z

Unfortunately this works locally. Any idea how to reproduce?

nre-ableton · 2020-10-12T07:56:14Z

It fails locally for me. Here's the stacktrace I get from running the unit tests in IntelliJ:

groovy.util.ResourceException: Cannot open URL: file:/home/nre/Code/nre-ableton/JenkinsPipelineUnit/src/test/jenkins/jenkinsfiles/Declarative_This_Jenkinsfile

	at groovy.util.GroovyScriptEngine.getResourceConnection(GroovyScriptEngine.java:411)
	at groovy.util.GroovyScriptEngine.loadScriptByName(GroovyScriptEngine.java:556)
	at groovy.util.GroovyScriptEngine$loadScriptByName$0.call(Unknown Source)
	at com.lesfurets.jenkins.unit.PipelineTestHelper.loadScript(PipelineTestHelper.groovy:399)
	at com.lesfurets.jenkins.unit.PipelineTestHelper$loadScript$5.callCurrent(Unknown Source)
	at com.lesfurets.jenkins.unit.PipelineTestHelper.runScript(PipelineTestHelper.groovy:413)
	at com.lesfurets.jenkins.unit.PipelineTestHelper$runScript$4.call(Unknown Source)
	at com.lesfurets.jenkins.unit.BasePipelineTest.runScript(BasePipelineTest.groovy:338)
	at com.lesfurets.jenkins.unit.BasePipelineTest$runScript.callCurrent(Unknown Source)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:52)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:154)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:166)
	at com.lesfurets.jenkins.unit.declarative.TestDeclarativePipeline.jenkinsfile_this(TestDeclarativePipeline.groovy:27)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
	at org.junit.runners.Suite.runChild(Suite.java:127)
	at org.junit.runners.Suite.runChild(Suite.java:26)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:220)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:53)

I would suggest making a fresh checkout with this branch or running git clean -dffx and then re-running the unit tests. Also, it might help to rebase this branch on upstream master, since there have been some other PRs merged since this one was created.

Willem1987 · 2020-10-14T17:43:00Z

I have overwritten my fork of master with upstream master and re-applied commit to that. Then i force pushed the state to the existing branch. I tried the git clean -dffx but locally i could not get it to break.
I hope the up to date master with the cherry picked commit will help.

Willem1987 · 2020-10-14T17:52:16Z

The appveyor seems to run the test and work? Could it be a jdk thing or specific environment?

I tried this test on a windows (virtual workstation) and macbook.

Willem1987 · 2020-10-14T18:06:00Z

I changed from oracle jdk 8 to openjdk 8 which i thought to have seen in the travis build.

openjdk version "1.8.0_265"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_265-b01)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.265-b01, mixed mode)

Willem1987 · 2020-10-14T18:45:34Z

Okay now im lost. I renamed the jenkinsfile to Declarative_thisObject_JenkinsFile and the test to jenkinsfile_thisObject and now it seems to work? So somehow this in a filename might cause problems? Or something else fixed it

src/test/groovy/com/lesfurets/jenkins/unit/declarative/TestDeclarativePipeline.groovy

stchar

Please improve tests. assertJobStatusSucces() is not enough IMHO

stchar

Could you please add few more changes in tests and I would be glad to merge it

stchar · 2020-10-17T07:32:26Z

src/test/jenkins/jenkinsfiles/Declarative_thisObject_JenkinsFile

+
+String testThis(Script scriptRef, String text){
+    echo "This is a script?: ${this == scriptRef}"
+    return text


return "$text: This is a script?: ${this == scriptRef}"

Would allow to:
assertCallStack().contains("pipeline unit tests completed: This is a script?: true")

So you can help other contributors to detect broken places in the code in later updates

Then we could only call the method in 1 place. I called it from environment, options, when, trigger and script content now.

Scratch that, it technically works, but the values returned would not be valid in real life. For test it is okay i think

I updated it a little to pass in Object. So that this always works and we can check instanceof

In addition to that i added an assert so that it may not contain false

…l make this.sh work and make this in the pipeline script passable to methods.

Willem1987 · 2020-12-02T07:57:53Z

@nre-ableton @stchar Is there anything i can do on this? I updated the MR according to comments i think. If i need to do anything let me know. I started using jenkinsPipelineUnit in our builds and would like the this ref feature.

nre-ableton · 2020-12-02T08:12:28Z

I'll let @stchar take things from here, since he's been the primary reviewer on this PR.

Willem1987 · 2021-05-02T07:52:58Z

I'll let @stchar take things from here, since he's been the primary reviewer on this PR.

@nre-ableton Though i understand this viewpoint, it has been months now. Is he still active? Is there anything i can do to further progress this?

nre-ableton · 2021-05-04T11:51:50Z

I'll let @stchar take things from here, since he's been the primary reviewer on this PR.

@nre-ableton Though i understand this viewpoint, it has been months now. Is he still active? Is there anything i can do to further progress this?

My understanding is that he's recently become a father, so I expect he's pretty busy (and also possibly on paternity leave). Probably doesn't hurt to ping him again (hi @stchar!), but I don't know when he'll be back.

Willem1987 · 2021-06-07T19:55:56Z

Closing due too revised insights from #299

nre-ableton reviewed Oct 5, 2020

View reviewed changes

src/test/groovy/com/lesfurets/jenkins/unit/declarative/TestDeclarativePipeline.groovy Outdated Show resolved Hide resolved

Willem1987 force-pushed the change-this-reference-to-script branch from a6df9ae to 722d5b8 Compare October 10, 2020 18:42

Willem1987 force-pushed the change-this-reference-to-script branch 2 times, most recently from c44f199 to e757d53 Compare October 14, 2020 17:38

Willem1987 force-pushed the change-this-reference-to-script branch from e757d53 to bf70041 Compare October 14, 2020 18:40

stchar reviewed Oct 16, 2020

View reviewed changes

src/test/groovy/com/lesfurets/jenkins/unit/declarative/TestDeclarativePipeline.groovy Show resolved Hide resolved

stchar requested changes Oct 16, 2020

View reviewed changes

Willem1987 force-pushed the change-this-reference-to-script branch 2 times, most recently from e12cdd3 to 4b7ab37 Compare October 16, 2020 14:35

Willem1987 requested a review from stchar October 16, 2020 19:42

stchar requested changes Oct 17, 2020

View reviewed changes

Willem1987 force-pushed the change-this-reference-to-script branch 6 times, most recently from eb26bee to cb81df0 Compare October 17, 2020 12:33

Rehydrate components with thisObject pointing to the script. This wil…

dcbddce

…l make this.sh work and make this in the pipeline script passable to methods.

Willem1987 force-pushed the change-this-reference-to-script branch from cb81df0 to dcbddce Compare October 17, 2020 13:03

Willem1987 requested a review from stchar October 19, 2020 12:40

Willem1987 closed this Jun 7, 2021

Conversation

Willem1987 commented Oct 1, 2020

Uh oh!

Uh oh!

Willem1987 commented Oct 10, 2020

Uh oh!

nre-ableton commented Oct 12, 2020

Uh oh!

Willem1987 commented Oct 14, 2020

Uh oh!

Willem1987 commented Oct 14, 2020

Uh oh!

Willem1987 commented Oct 14, 2020

Uh oh!

Willem1987 commented Oct 14, 2020

Uh oh!

Uh oh!

stchar left a comment

Choose a reason for hiding this comment

Uh oh!

stchar left a comment

Choose a reason for hiding this comment

Uh oh!

stchar Oct 17, 2020

Choose a reason for hiding this comment

Uh oh!

Willem1987 Oct 17, 2020

Choose a reason for hiding this comment

Uh oh!

Willem1987 Oct 17, 2020

Choose a reason for hiding this comment

Uh oh!

Willem1987 Oct 17, 2020

Choose a reason for hiding this comment

Uh oh!

Willem1987 Oct 17, 2020

Choose a reason for hiding this comment

Uh oh!

Willem1987 commented Dec 2, 2020

Uh oh!

nre-ableton commented Dec 2, 2020

Uh oh!

Willem1987 commented May 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nre-ableton commented May 4, 2021

Uh oh!

Willem1987 commented Jun 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Willem1987 commented May 2, 2021 •

edited

Loading