Add Kubernetes and file operations steps mocks#354
Open
mahmoud-ashi wants to merge 1 commit intojenkinsci:masterfrom
Open
Add Kubernetes and file operations steps mocks#354mahmoud-ashi wants to merge 1 commit intojenkinsci:masterfrom
mahmoud-ashi wants to merge 1 commit intojenkinsci:masterfrom
Conversation
Add mocks for steps from https://github.com/jenkinsci/kubernetes-plugin Add mocks for steps from https://github.com/jenkinsci/file-operations-plugin Add mock for `libraryResource`, `lock`, `powershell` Fix recently added mock for `timeout` with integer argument
nre-ableton
requested changes
Mar 24, 2021
Contributor
nre-ableton
left a comment
There was a problem hiding this comment.
Please split 963ce57 up into 5 commits:
- One for the
libraryResourcemock - One for the
lockmock - One for the
powershellmock - One for the
timeoutfix - One for the
unstashfix (which should probably include a corresponding fix forstash, since these steps are related).
That will make this PR much easier to review.
As for the mocks for Kubernetes and file-operations-plugins, please also split those into separate commits and make new PRs for each of them. I am personally disinclined to include mocks for such plugins in this library, since I believe that it should only cover base pipeline steps (otherwise, there is no limit to how much this library will grow, and it will get more difficult to maintain). However, I may be convinced otherwise, but we should have these discussions with other maintainers/contributors in a separate PR.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mocks for steps from https://github.com/jenkinsci/kubernetes-plugin
Add mocks for steps from https://github.com/jenkinsci/file-operations-plugin
Add mock for
libraryResource,lock,powershellFix mock for
unstashstepFix recently added mock for
timeoutwith integer argument