Open
Conversation
Author
|
@nre-ableton any chance you could give this a look? |
nre-ableton
requested changes
Feb 19, 2026
Contributor
nre-ableton
left a comment
There was a problem hiding this comment.
First of all, thanks for your PR and sorry for the delay in reviewing. It was indeed in my GitHub notifications, but things have been quite busy at work recently (same old excuses 🙃).
Anyways, the concept of this PR seems fine, but I am not wild about the API. In general, variables/methods/classes/etc with And in the name should be an indication that they are trying to do too many things and should be refactored accordingly.
I would recommend the following:
- Remove
shouldCacheScriptsAndLibrariesand replace with two distinct properties:cacheScriptsandcacheLibraries - Eliminate the
withShouldCacheScriptsAndLibrariesmethod and simply allow users to set the above properties as usual - Use the respective fields when clearing cached classes/libraries
I have other minor suggestions, but I don't think they are worth discussing until we figure out the "big picture" here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a script and library cache to the PipelineTestHelper, this helped reduce the time a suite of tests took on a complex pipeline library from several minutes to ~30 seconds, as each test previous took ~7 seconds to load the script and the library. Any changes to mocks or script/libraries during test execution would be ignored by the caching, so the cache is disabled by default with a flag to enable it.
Testing done
Submitter checklist