-
Notifications
You must be signed in to change notification settings - Fork 249
Adapt to New credentials dialog (don't merge)
#2565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
New credentials dialogNew credentials dialog (don't merge)
|
Ready for review but credentials plugin will need merging first: jenkinsci/credentials-plugin#992 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems reasonable, marking as draft to prevent accidental merging until we are ready
| <artifactItem> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>credentials</artifactId> | ||
| <version>1578.v4ea_f41d464ed</version> | ||
| <type>hpi</type> | ||
| </artifactItem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be reverted before merge
| <artifactItem> | |
| <groupId>org.jenkins-ci.plugins</groupId> | |
| <artifactId>credentials</artifactId> | |
| <version>1578.v4ea_f41d464ed</version> | |
| <type>hpi</type> | |
| </artifactItem> |
| <environmentVariables> | ||
| <!-- Use local version of the plugin over the released one ATH would otherwise use --> | ||
| <LOCAL_JARS>target/credentials.hpi</LOCAL_JARS> | ||
| </environmentVariables> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be reverted before merge
| <environmentVariables> | |
| <!-- Use local version of the plugin over the released one ATH would otherwise use --> | |
| <LOCAL_JARS>target/credentials.hpi</LOCAL_JARS> | |
| </environmentVariables> |
jenkinsci/credentials-plugin#992
Testing done
Submitter checklist