Skip to content

Wait for 'Build Now' link visibility before clicking #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LakshyaBagani wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Wait for 'Build Now' link visibility before clicking #2589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/org/jenkinsci/test/acceptance/po/Job.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,8 @@ public Build scheduleBuild(Map<String, ?> params) {
open();
int nb = getJson().get("nextBuildNumber").intValue();
if (parameters.isEmpty()) {
// Wait for "Build Now" link to become visible (JS shows it after page load)
waitFor(by.link("Build Now"));
Comment on lines +365 to +366
Copy link
Member

@jtnord jtnord Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this fixes the issue, as this is looking for a a element with the text Build Now and IIUC the upstream change does not change that.
In essence I think this is just wasting some CPU such that the timing changes enough that clicking the link works.

Additionally if you do need to wait and then interact with the thing you waited for then use the WebElement returned by waitFor

Copy link
Member

@timja timja Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this would work, please test this in your PR in the jenkins repository using an incremental build when the tests here pass

clickLink("Build Now");
// the notification bar can place itslef over other elements
// so wait for it to be added and then disappear
Expand Down