Skip to content

Adapt Script Console for experimental Manage Jenkins UI #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 5 commits into from
Jan 23, 2026
Merged

Adapt Script Console for experimental Manage Jenkins UI #2592

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af313aa
Adjust Run command
janfaracik Jan 22, 2026
3a82329
Test PR
janfaracik Jan 22, 2026
c357bb9
Merge branch 'master' into test-11333
janfaracik Jan 23, 2026
9c89ee4
Discard changes to Jenkinsfile
timja Jan 23, 2026
b2fd52b
Discard changes to pom.xml
timja Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ if (needSplittingFromWorkspace) {
}

def axes = [
jenkinsVersions: ['lts', 'latest'],
jenkinsVersions: ['latest'],
platforms: ['linux'],
jdks: [21, 25],
browsers: ['firefox'],
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<properties>
<changelist>999999-SNAPSHOT</changelist>
<spotbugs.skip>true</spotbugs.skip>
<jenkins.version>2.547</jenkins.version>
<jenkins.version>2.548-rc37927.a_a_13b_d4e0224</jenkins.version>
<selenium.version>4.40.0</selenium.version>
<!-- aligned with selenium -->
<guava.version>33.5.0-jre</guava.version>
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/jenkinsci/test/acceptance/po/Node.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public String runScript(String script, int timeoutSeconds, Object... args) {
visit("script");
CodeMirror cm = new CodeMirror(this, "/script");
cm.set(String.format(script, args));
clickButton("Run");
find(by.css("button[value='Run']")).click();
Copy link
Member

@jtnord jtnord Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this imply that clickButton should be fixed after all this is a button and it has the text Run?
If we have multiple buttons all with the same value - then this would appear to be a UX issue as well. If we need to disambiguate the main "run" from an example script "run" then why are we not using IDs or data-test-ids

Copy link
Member

@timja timja Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text is different, its just the button has the text Run example but because it does a contains it breaks it.

It uses a contains because some buttons have SVGs in them so its a workaround for that.

IDs or data-test-ids would work but this also works fine too.

Copy link
Member

@jtnord jtnord Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so to cope with svg we should be using innerText and if that SVG has text then it should be included in the match (the string supplied to clickButton(String)) as it is part of the button text?


waitFor(by.xpath("//h2[contains(text(), 'Result')]"), timeoutSeconds);

Expand Down