some diagnostics for observed timeouts#2626
Draft
jtnord wants to merge 10 commits intojenkinsci:masterfrom
Draft
some diagnostics for observed timeouts#2626jtnord wants to merge 10 commits intojenkinsci:masterfrom
jtnord wants to merge 10 commits intojenkinsci:masterfrom
Conversation
``` org.openqa.selenium.TimeoutException: Expected condition failed: Timed out waiting on '#workflow-editor-1 .ace_text-input' to be rendered. (tried for 20 seconds with 500 milliseconds interval) Build info: version: '4.40.0', revision: 'b3333f1' System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.12.55+', java.version: '21.0.10' Driver info: driver.version: unknown at org.openqa.selenium.support.ui.FluentWait.timeoutException(FluentWait.java:276) at org.jenkinsci.test.acceptance.junit.Wait.timeoutException(Wait.java:191) at org.openqa.selenium.support.ui.FluentWait.until(FluentWait.java:231) at org.jenkinsci.test.acceptance.junit.Wait.until(Wait.java:120) at org.jenkinsci.test.acceptance.po.WorkflowJob.waitForRenderOf(WorkflowJob.java:79) at org.jenkinsci.test.acceptance.po.WorkflowJob$1.waitFor(WorkflowJob.java:70) at org.jenkinsci.test.acceptance.po.WorkflowJob$1.set(WorkflowJob.java:54) ```
jtnord
commented
Feb 26, 2026
| // scroll into view whilst we are waiting | ||
| WebElement placeholder = driver.findElement(By.className("workflow-editor-wrapper")); | ||
| Actions actions = new Actions(driver); | ||
| actions.scrollToElement(placeholder); |
Member
Author
There was a problem hiding this comment.
no longer use the class `workflow-editor-1` (or `workflow-editor`) rather we use the path to the script and then find the `ace_editor` sibling
jtnord
commented
Feb 26, 2026
| private String waitFor(@NonNull final String selector) { | ||
| waitForRenderOf(selector + " .ace_text-input", getJenkins()); | ||
| return selector; | ||
| // scroll into view (by performing a click :-o) so we can see the script being set. |
Member
Author
There was a problem hiding this comment.
can not use Actions().scrollTo(element) -> SeleniumHQ/selenium#17141
jtnord
commented
Feb 26, 2026
| // We can not do in a cross platform way because mac doesn't use <ctrl>+a for "select all" shortcut | ||
| WebElement aceEditorHolder = resolve(); | ||
|
|
||
| // scroll into view https://github.com/SeleniumHQ/selenium/issues/17141#issuecomment-3969129937 |
Member
Author
There was a problem hiding this comment.
jtnord
commented
Feb 26, 2026
| // super.resolve calls CapybaraPortingLayerImpl.find, which calls isDisplayed and fails. | ||
| // so find directly and wait for javascript to have created all the parts. | ||
| return waitFor(driver) | ||
| .ignoring(NoSuchElementException.class, StaleElementReferenceException.class) |
Member
Author
There was a problem hiding this comment.
NoSuchElementException will be thrown until the ace javascript has set things up
StaleElementReferenceException could be thrown if the ace editor setup script is running and updating things beween us getting one of the elements and then searching for the next
jtnord
commented
Feb 26, 2026
| } | ||
|
|
||
| private boolean isMac() { | ||
| if (driver instanceof HasCapabilities capabilityOwner) { |
Member
Author
There was a problem hiding this comment.
at least the RemoteWebdriver, ChromeDriver and Firefox driver all support this interface.
jtnord
commented
Feb 26, 2026
| if (driver instanceof HasCapabilities capabilityOwner) { | ||
| Capabilities caps = capabilityOwner.getCapabilities(); | ||
| Platform platform = caps.getPlatformName(); | ||
| if (platform != null) { |
Member
Author
There was a problem hiding this comment.
it's nullable but was present when using the standalone-firefox and standalone-chrome containers and when using a local firefox.
jtnord
commented
Feb 26, 2026
| @Override | ||
| public void set(String text) { | ||
| try { | ||
| super.set(text); |
Member
Author
There was a problem hiding this comment.
this would have been failing for the previous few years!
jtnord
commented
Feb 27, 2026
| .sendKeys("a") | ||
| .keyUp(controlKey) | ||
| .sendKeys(Keys.DELETE) | ||
| .sendKeys(text) |
Member
Author
There was a problem hiding this comment.
Alas this does not work as the ACE Editor adds auto complete for brached xxx{<CR> it automatically adds a closing brace and positions the cursor..
So sending
node {
sh "sleep 1 || true"
}results in the pipeline script of
node {
sh "sleep 1 || true"
}
}which is bogus...
in the case of an opening brace followed by enter ACE editor will helpfully add a closing brace and position the cursor between the braces. This caused corruption of the pipeline text when entered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing done
Submitter checklist