Skip to content

Adapt matrix-auth tests to its redesign#2665

Draft
timja wants to merge 6 commits intojenkinsci:masterfrom
timja:test-matrix-auth
Draft

Adapt matrix-auth tests to its redesign#2665
timja wants to merge 6 commits intojenkinsci:masterfrom
timja:test-matrix-auth

Conversation

@timja
Copy link
Copy Markdown
Member

@timja timja commented Apr 3, 2026

jenkinsci/matrix-auth-plugin#190

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@timja timja changed the title Test matrix-auth Adapt matrix-auth tests to its redesign Apr 3, 2026
public User signup(String name) {
return signup().password(name)
return signup()
.username(name)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in here aren't necessary but its pained me for a long time watching the tests fill out the fields in a random order. It should fill them the way a user would.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant