Test 'Refine System Log' pages#2685
Open
janfaracik wants to merge 4 commits intojenkinsci:masterfrom
Open
Conversation
jtnord
requested changes
Apr 21, 2026
| j.visit("log/new"); | ||
| j.visit("log"); | ||
|
|
||
| // This can be simplified to clicking the Add recorder button once the baseline is high enough |
Member
There was a problem hiding this comment.
isn't this always a button? why not use the button finder?
Comment on lines
+30
to
+31
| )).click(); | ||
| j.waitFor(by.xpath("//form[contains(@name, 'configSubmit')]"), 10); |
Member
There was a problem hiding this comment.
if this is using a diaglog (which it looks like from the upstream) then this method of obtaining the button is incorrect.
Check the helpers for runThenHandleDialog (or somethign similar) (TL;DR this can match whilst the dialog is animating into view, and cause the click to miss)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests jenkinsci/jenkins#26614
Testing done
Submitter checklist