[JENKINS-73509] GCC parser does not handle cc1/cc1plus warnings #1253
+149
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhafner
reviewed
Oct 8, 2025
uhafner
reviewed
Oct 8, 2025
akash-manna-sky
force-pushed
the
JENKINS-73509
branch
from
d95815f to
569f920
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
uhafner
requested changes
Nov 5, 2025
| @Override | ||
| protected Optional<Issue> createIssue(final Matcher matcher, final LookaheadStream lookahead, | ||
| final IssueBuilder builder) { | ||
| // Extract named groups from the regex match |
There was a problem hiding this comment.
Do not comment things that are expressed as code.
Suggested change
| // Extract named groups from the regex match |
| String severityLevel = matcher.group("severity"); // warning, error, or note | ||
| String messageContent = matcher.group("message"); // The actual message text | ||
|
|
||
| // Validate that all required fields are present |
There was a problem hiding this comment.
Suggested change
| // Validate that all required fields are present |
Comment on lines
80
to
102
| /** | ||
| * Maps the severity string from compiler output to a Severity enum value. | ||
| * | ||
| * Mapping: | ||
| * - "warning" → WARNING_NORMAL | ||
| * - "error" → WARNING_HIGH | ||
| * - "note" → WARNING_LOW | ||
| * - default → WARNING_NORMAL | ||
| * | ||
| * @param severityString the severity string from the compiler output | ||
| * (warning/error/note) | ||
| * @return the corresponding Severity enum value for issue classification | ||
| */ | ||
| private Severity mapSeverity(final String severityString) { | ||
| if (equalsIgnoreCase(severityString, "warning")) { | ||
| return Severity.WARNING_NORMAL; | ||
| } else if (equalsIgnoreCase(severityString, "error")) { | ||
| return Severity.WARNING_HIGH; | ||
| } else if (equalsIgnoreCase(severityString, "note")) { | ||
| return Severity.WARNING_LOW; | ||
| } | ||
| return Severity.WARNING_NORMAL; // Default fallback | ||
| } |
There was a problem hiding this comment.
Replace with Severity.guessSeverity
Comment on lines
110
to
114
| private boolean isCc1MessageContinuation(final LookaheadStream lookahead) { | ||
| var peek = lookahead.peekNext(); | ||
| if (peek.length() < 3) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Can't we reuse the same method from the Gcc4Parser?
| */ | ||
| private static final String GCC_CC1_WARNING_PATTERN = "^(?:In .+?:\\s*)?" // Optional context prefix (e.g., "In member function:") | ||
| + "(?<compiler>cc1(?:plus)?):\\s*" // Compiler name: cc1 or cc1plus | ||
| + "(?<severity>warning|error|note):\\s*" // Severity level |
There was a problem hiding this comment.
Can you override, this will speed up the parser:
@Override
protected boolean isLineInteresting(final String line) {
return line.contains("warning") || line.contains("error") || line.contains("note");
}
|
Hello @uhafner I have implemented all suggested changes. Please review the changes. |
uhafner
approved these changes
Nov 5, 2025
|
Thanks! I squashed your commits, please make sure that you write meaningful messages the next time... |
|
Thanks! I’ll make sure to write clear and meaningful commit messages next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-73509
GCC parser does not handle cc1/cc1plus warnings
Testing done
Submitter checklist