Skip to content

[JENKINS-75743] Gcc warnings report format confusion #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[JENKINS-75743] Gcc warnings report format confusion #1261

wants to merge 4 commits into from
+47 −5

Conversation

@akash-manna-sky
Copy link
Contributor

@akash-manna-sky akash-manna-sky commented Nov 5, 2025

Gcc warnings report format confusion

JENKINS-75743

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@uhafner uhafner added the enhancement Enhancement of existing functionality label Nov 5, 2025
uhafner
uhafner requested changes Nov 5, 2025
View reviewed changes
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Can you use HTML for the message?

src/main/java/edu/hm/hafner/analysis/registry/Gcc4Descriptor.java Outdated

@Override
public String getHelp() {
return "Parses warnings and errors generated by GCC version 4 and newer "
Copy link
Member

@uhafner uhafner Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write that as HTML? E.g. as done in PnpmAuditDescriptor or EclipseDescriptor.java? Newlines are filtered when shown in the HTML UI.

Copy link
Contributor Author

@akash-manna-sky akash-manna-sky Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I have implemented the suggested changes. I also updated SUPPORTED-FORMATS.md file. Is that right? If not I will revert the SUPPORTED-FORMATS.md file.

@uhafner uhafner marked this pull request as ready for review November 5, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uhafner uhafner Awaiting requested review from uhafner

Assignees

@uhafner uhafner

Labels

enhancement Enhancement of existing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akash-manna-sky @uhafner