Removes Commons Lang usage by alecharp · Pull Request #776 · jenkinsci/artifact-manager-s3-plugin

alecharp · 2026-01-19T16:26:19Z

This removes all usage of Commons Lang library.

Testing done

Ran mvn verify locally.

Submitter checklist

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests that demonstrate the feature works or the issue is fixed

jglick

Seems to be incorrect in the first two places I checked. Was this produced by some automated rewrite tool?

jglick · 2026-01-22T20:47:47Z

src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStore.java

        try {
            Properties props = new Properties();
-            boolean hasCustomEndpoint = StringUtils.isNotBlank(getConfiguration().getResolvedCustomEndpoint());
+            boolean hasCustomEndpoint = !(getConfiguration().getResolvedCustomEndpoint() != null && getConfiguration().getResolvedCustomEndpoint().isBlank());


Wait, what? This is equivalent to

Suggested change

boolean hasCustomEndpoint = !(getConfiguration().getResolvedCustomEndpoint() != null && getConfiguration().getResolvedCustomEndpoint().isBlank());

boolean hasCustomEndpoint = getConfiguration().getResolvedCustomEndpoint() == null || !getConfiguration().getResolvedCustomEndpoint().isBlank();

A null value was clearly supposed to be no endpoint.

jglick · 2026-01-22T20:51:07Z

src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStore.java

+            boolean hasCustomEndpoint = !(getConfiguration().getResolvedCustomEndpoint() != null && getConfiguration().getResolvedCustomEndpoint().isBlank());

-            if(StringUtils.isNotBlank(getRegion())) {
+            if(!getRegion().isBlank()) {


Also an incorrect translation of the original code, though in this case the original code does not seem to have made any sense; from my reading, it could never have been null or blank.

alecharp · 2026-01-29T11:49:15Z

Was this produced by some automated rewrite tool?

No it was not. Only used an apparently unfocussed brain.

@jglick

Thanks @jglick.

jglick · 2026-03-16T19:56:17Z

src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStore.java

            Properties props = new Properties();
-            boolean hasCustomEndpoint = StringUtils.isNotBlank(getConfiguration().getResolvedCustomEndpoint());
+            String resolvedCustomEndpoint = getConfiguration().getResolvedCustomEndpoint();
+            boolean hasCustomEndpoint = resolvedCustomEndpoint == null || !resolvedCustomEndpoint.isBlank();


This still looks wrong. It has a custom endpoint if the resolved custom endpoint is not null and is not blank. Right?

Copilot

Pull request overview

This PR removes usage of Apache commons-lang v2 utilities from the S3 artifact manager plugin, replacing them with JDK equivalents and enabling an explicit build-time ban on commons-lang 2.

Changes:

Replace StringUtils blank/abbreviate helpers with JDK String::isBlank + manual truncation logic.
Replace RandomStringUtils usage in tests with UUID.
Enable ban-commons-lang-2 enforcement via a Maven property.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`src/test/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3AbstractTest.java`	Switches unique test prefix generation from `RandomStringUtils` to `UUID` (with truncation).
`src/test/java/io/jenkins/plugins/artifact_manager_jclouds/s3/LocalStackIntegrationTest.java`	Replaces `StringUtils.isBlank` with a null-safe `isBlank` check for region selection.
`src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java`	Replaces `StringUtils` usages in endpoint/validation logic and error message abbreviation.
`src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStore.java`	Replaces `StringUtils` usages in endpoint detection, presigner configuration, and descriptor config check.
`pom.xml`	Adds property to enforce banning `commons-lang` 2.

Comments suppressed due to low confidence (1)

src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java:265

getResolvedCustomEndpoint() currently enters the block when customEndpoint is null because the condition is customEndpoint == null || !customEndpoint.isBlank(). This causes the method to return values like https://null and treats a missing endpoint as configured. The condition should require a non-null, non-blank customEndpoint (and ideally trim it) before constructing the URL.

    public String getResolvedCustomEndpoint() {
        if(customEndpoint == null || !customEndpoint.isBlank()) {
            String protocol;
            if(getUseHttp()) {
                protocol = "http";
            } else {
                protocol = "https";
            }
            return protocol + "://" + customEndpoint;
        }
        return null;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java

@@ -368,7 +368,7 @@ public FormValidation doCheckContainer(@QueryParameter String container){

    public FormValidation doCheckPrefix(@QueryParameter String prefix){
        FormValidation ret;
-        if (StringUtils.isBlank(prefix)) {
+        if (prefix.isBlank()) {
            ret = FormValidation.ok("Artifacts will be stored in the root folder of the S3 Bucket.");
        } else if (prefix.endsWith("/")) {


src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java

    public FormValidation doCheckCustomSigningRegion(@QueryParameter String customSigningRegion) {
        FormValidation ret;
-        if (StringUtils.isBlank(customSigningRegion) && StringUtils.isNotBlank(customEndpoint)) {
+        if (customSigningRegion != null && customSigningRegion.isBlank() && (customEndpoint == null || !customEndpoint.isBlank())) {


src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java

    public FormValidation doCheckCustomEndpoint(@QueryParameter String customEndpoint) {
        FormValidation ret = FormValidation.ok();
-        if (!StringUtils.isBlank(customEndpoint) && !endPointPattern.matcher(customEndpoint).matches()) {
+        if (!customEndpoint.isBlank() && !endPointPattern.matcher(customEndpoint).matches()) {


src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStore.java

@@ -141,7 +141,7 @@ public BlobStoreContext getContext() throws IOException {
                    .overrides(props);

            if (hasCustomEndpoint) {
-                builder = builder.endpoint(getConfiguration().getResolvedCustomEndpoint());
+                builder = builder.endpoint(resolvedCustomEndpoint);
            }


src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStore.java

        String customRegion = getConfiguration().getCustomSigningRegion();
-        if(StringUtils.isBlank(customRegion)) {
+        if(customRegion.isBlank()) {
            customRegion = getConfiguration().getRegion().id();
        }
-        if(StringUtils.isNotBlank(customRegion)) {
+        if(!customRegion.isBlank()) {
            presignerBuilder.region(Region.of(customRegion));
        }


src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStore.java

         */
        public boolean isConfigured(){
-            return StringUtils.isNotBlank(S3BlobStoreConfig.get().getContainer());
+            return !S3BlobStoreConfig.get().getContainer().isBlank();


src/test/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3AbstractTest.java

    public static String generateUniquePrefix() {
        return String.format("%s%s-%s/", S3_DIR, ZonedDateTime.now().format(DateTimeFormatter.ISO_INSTANT),
-                RandomStringUtils.randomAlphabetic(4).toLowerCase());
+                UUID.randomUUID().toString().substring(0, 4).toLowerCase());


Removes Commons Lang usage

5f3c0b2

alecharp requested a review from a team as a code owner January 19, 2026 16:26

jglick added the developer label Jan 22, 2026

jglick requested changes Jan 22, 2026

View reviewed changes

alecharp and others added 2 commits January 29, 2026 12:59

Fix incorrect translation of isNotBlank

a986c61

Thanks @jglick.

Merge branch 'master' into chore/removes-commons-lang-usage

679d887

jglick reviewed Mar 16, 2026

View reviewed changes

jglick requested a review from Copilot March 16, 2026 19:57

Copilot started reviewing on behalf of jglick March 16, 2026 19:58 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removes Commons Lang usage#776

Removes Commons Lang usage#776
alecharp wants to merge 3 commits intojenkinsci:masterfrom
alecharp:chore/removes-commons-lang-usage

alecharp commented Jan 19, 2026 •

edited

Loading

Uh oh!

jglick left a comment

Uh oh!

jglick Jan 22, 2026

Uh oh!

jglick Jan 22, 2026

Uh oh!

alecharp commented Jan 29, 2026

Uh oh!

jglick Mar 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	boolean hasCustomEndpoint = !(getConfiguration().getResolvedCustomEndpoint() != null && getConfiguration().getResolvedCustomEndpoint().isBlank());
	boolean hasCustomEndpoint = getConfiguration().getResolvedCustomEndpoint() == null \|\| !getConfiguration().getResolvedCustomEndpoint().isBlank();

Conversation

alecharp commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing done

Submitter checklist

Uh oh!

jglick left a comment

Choose a reason for hiding this comment

Uh oh!

jglick Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

jglick Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

alecharp commented Jan 29, 2026

Uh oh!

jglick Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alecharp commented Jan 19, 2026 •

edited

Loading