Package CRT-based HTTP Client and S3 Transfer Manager in AWS SDK for Java 2.x #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
added
the
enhancement
basil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package https://aws.amazon.com/blogs/developer/introducing-crt-based-s3-client-and-the-s3-transfer-manager-in-the-aws-sdk-for-java-2-x/ using a separate module for CRT because it is so large (17 MiB). I have tested this only lightly and it did not work out of the box due to class loading issues. I was able to work around those with core's
SetContextClassLoader, but I did not have time to investigate the root cause yet. So I am keeping this PR in draft. With more testing and debugging, perhaps we can find the root cause and get this functionality to work without class loading errors out of the box; otherwise, perhaps we can document the workaround. I am not entirely sure if these libraries are actually needed, so if they are not needed then this PR can simply be closed without any issue.