Adding support for VMLimit in AzureVMTemplateBuilder #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwaysharsha
force-pushed
the
hs-vmtemplate-maxlimit
branch
from
629a9fa to
9ffd059
Compare
alwaysharsha
force-pushed
the
hs-vmtemplate-maxlimit
branch
from
9a94207 to
d50a471
Compare
timja
reviewed
Apr 8, 2025
| @@ -96,7 +98,7 @@ public AzureVMAgentTemplate build() { | |||
| fluent.getDescription(), | |||
| fluent.getLabels(), | |||
| fluent.getLocation(), | |||
| null, | |||
| new NoAvailabilityRequired(), | |||
timja
reviewed
Apr 8, 2025
|
|
||
| public class AzureVMTemplateBuilder extends AzureVMTemplateFluent<AzureVMTemplateBuilder> { | ||
|
|
||
| private AzureVMTemplateFluent<?> fluent; | ||
|
|
||
| public AzureVMTemplateBuilder() { | ||
| this.fluent = this; | ||
| fluent.withMaxVirtualMachinesLimit("10"); |
There was a problem hiding this comment.
this isn't right it shouldn't be here
timja
reviewed
Apr 8, 2025
|
|
||
| public class AzureVMTemplateBuilder extends AzureVMTemplateFluent<AzureVMTemplateBuilder> { | ||
|
|
||
| private AzureVMTemplateFluent<?> fluent; | ||
|
|
||
| public AzureVMTemplateBuilder() { | ||
| this.fluent = this; | ||
| fluent.withMaxVirtualMachinesLimit("10"); | ||
| } | ||
|
|
||
| public AzureVMTemplateBuilder(AzureVMAgentTemplate template) { |
There was a problem hiding this comment.
you also need to call setMaxVirtualMachinesLimit in the build method further down
timja
reviewed
Apr 8, 2025
| @@ -57,6 +59,7 @@ public class AzureVMTemplateFluent<T extends AzureVMTemplateFluent<T>> { | |||
| private List<AzureTagPair> cloudTags; | |||
|
|
|||
| public AzureVMTemplateFluent() { | |||
| maxVirtualMachinesLimit = "10"; | |||
There was a problem hiding this comment.
Suggested change
| maxVirtualMachinesLimit = "10"; | |
| maxVirtualMachinesLimit = 10; |
timja
reviewed
Apr 8, 2025
| @@ -12,6 +12,8 @@ | |||
|
|
|||
| public class AzureVMTemplateFluent<T extends AzureVMTemplateFluent<T>> { | |||
|
|
|||
| private String maxVirtualMachinesLimit; | |||
There was a problem hiding this comment.
Suggested change
| private String maxVirtualMachinesLimit; | |
| private int maxVirtualMachinesLimit; |
timja
reviewed
Apr 8, 2025
| @@ -73,6 +76,11 @@ public AzureVMTemplateFluent() { | |||
| } | |||
|
|
|||
| //CHECKSTYLE:OFF | |||
| public T withMaxVirtualMachinesLimit(String maxVirtualMachinesLimit) { | |||
There was a problem hiding this comment.
Suggested change
| public T withMaxVirtualMachinesLimit(String maxVirtualMachinesLimit) { | |
| public T withMaxVirtualMachinesLimit(int maxVirtualMachinesLimit) { |
timja
reviewed
Apr 8, 2025
| @@ -208,6 +216,10 @@ public T withAdminCredential(String credentialsId) { | |||
| } | |||
| //CHECKSTYLE:ON | |||
|
|
|||
| public String getMaxVirtualMachinesLimit() { | |||
There was a problem hiding this comment.
Suggested change
| public String getMaxVirtualMachinesLimit() { | |
| public int getMaxVirtualMachinesLimit() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done
Submitter checklist