Open
Conversation
fa687b0 to
d7ca827
Compare
6 tasks
61aea30 to
535295b
Compare
535295b to
a8b31af
Compare
Author
|
If any interest @nfalco79 |
nfalco79
reviewed
Mar 12, 2026
| this.hash = hash; | ||
| } | ||
|
|
||
| @JsonProperty("hash") |
Member
There was a problem hiding this comment.
For what this setter is used for? Does jackson 3 fails to use setHash method?
Author
There was a problem hiding this comment.
I don't remember the cause, but one test was failing. I think there was a confusion with "hash" an "id" field at some point.
I don't know much more about the codebase or webhook payload.
Author
There was a problem hiding this comment.
Without this BitbucketServerPullRequestEventTest#updatePayload fail
assertThat(event.getPullRequest().getDestination().getCommit().getHash())
.isEqualTo("d235f0c0aa22f4c75b2fb63b217e39e2d3c29f49");which return null
Which confuses me is the "id" on the JsonCreator
@JsonCreator
public BitbucketServerCommit(@NonNull @JsonProperty("message") String message,
@NonNull @JsonProperty("id") String hash,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate to Jackson3
Jackson2 remains a dependency because of scribejava-core (looks like a dormant library still supporting Java 7. So I have some doubt it will ever be migrated to Jackson3. Just in case I submited a PR for this library as well: scribejava/scribejava#1088)
I just rely on existing tests
Feel free to take a look at this PR or park it for later
Your checklist for this pull request