-
Notifications
You must be signed in to change notification settings - Fork 64
wip: attempts at caching Maven local repo #4667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I would love it if you would be willing to include the JGit 7.2 and Mina SSHD 2.15.0 changes from: Also no problem if you don't include it, but it would help me know that the changes in those two pull requests are not harmful |
cb96d61 to
02a1f3c
Compare
I'm not sure to understand your request @MarkEWaite ? |
|
Retrying following @alecharp pointer: running the command Without using ACP, it tooks around 8m17 to generate a ~1.6Gb maven repo, mapping to a 1.2 Gb tar archive in the S3 PVC. |
02a1f3c to
cc92a25
Compare
With ACP: 2min26 |
Now it has been bootstrapped: 6s \o/ Let's wait for the result in #4669 (comment) (1.2 instead of 6 Gb file which changes the way S3 behaves - < 5 Gb) |
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
ce43631 to
b0372d6
Compare
Signed-off-by: Damien Duportal <[email protected]>
|
New retry with b0372d6 (and 7b8c4ae) based on @alecharp pointers:
=> resulting m2 local repo is 1.9 Gb, with a 1.6 Gb archive |
basil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Thanks for the reminder. We had this in mind from the beginning also (you explained it to me during FOSDEM which was a discovery as It helped us understand why the "pre warm" step in "prep" was not sufficient enough). We did load the cache during all the tests with the following patterns:
That being said: this cache population is not good enough (as we still had ACP errors even when using it). I want to explore running a modified PCT (3 lines x all PCTs all in parallel) which would only run a basic test to populate the cache without wasting too much machine time then => Besides the need for many agents, the risk is to have a too big archive at the end. But this could be circumvented by providing the cache in the node VM template (Adding 10 Gb to an AMI is roughly adding 10s to 20s on the VM boot time). It would avoid using S3 or any centralized system (as it would be distributed on each node). |
|
If it proves worth and scalable, we could explore your proposal by building the cache from many other plugins before entering the BOM. |
|
Closing as the implementation will be somewhere else. Works very well! |
Ref. jenkins-infra/helpdesk#4525
this PR is currently a playground (hence the draft + WiP status) to evaluate if the caching through the S3 PVC is worth it