Merged
Conversation
Not exactly sure how I hit it but was getting a massive stacktrace with a nullpointer
Member
Member
|
I assume the reason themes aren't working is this line? Should be safe to remove? |
Member
timja
reviewed
Mar 13, 2026
...com/smartcodeltd/jenkinsci/plugins/buildmonitor/viewmodel/features/HasBadgesBadgePlugin.java
Outdated
Show resolved
Hide resolved
Member
Author
|
What are your thoughts @timja? There's a few issues but nothing major right now, definitely needs some iteration but would be good to get it out into the wild |
timja
approved these changes
Mar 14, 2026
Member
timja
left a comment
There was a problem hiding this comment.
There’s some minor things left but they can be small follow ups
mawinter69
reviewed
Mar 14, 2026
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <configuration> | ||
| <source>17</source> |
There was a problem hiding this comment.
Don't hard code the java version. The required java version is set by the parent pom.
This was referenced Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The intention is to overhaul the plugin, using a modern framework and design system, to ensure it's straightforward to maintain going forward. It takes heavy inspiration from the structure of http://github.com/jenkinsci/pipeline-graph-view-plugin/ - I've found that that works really quite well and makes development easy.
What's new?
Closes #61
Closes #348
Closes #743
Closes #744
Closes #747
TODO
Testing done
Submitter checklist