Skip to content

Revamp plugin#1108

Merged
janfaracik merged 137 commits intojenkinsci:masterfrom
janfaracik:move-to-react
Mar 14, 2026
Merged

Revamp plugin#1108
janfaracik merged 137 commits intojenkinsci:masterfrom
janfaracik:move-to-react

Conversation

@janfaracik
Copy link
Copy Markdown
Member

@janfaracik janfaracik commented May 10, 2025

image image image

The intention is to overhaul the plugin, using a modern framework and design system, to ensure it's straightforward to maintain going forward. It takes heavy inspiration from the structure of http://github.com/jenkinsci/pipeline-graph-view-plugin/ - I've found that that works really quite well and makes development easy.

What's new?

  • New user interface
  • Pages can now have descriptions (appears in the header)
  • Reduce animations has been replaced with a media query (set reduced animations in your system settings instead)
  • New codebase in React
    • React 19, Vite, Rspack

Closes #61
Closes #348
Closes #743
Closes #744
Closes #747

TODO

  • Improve error handling
  • Improve badges
  • Add JUnit support
  • Add cause/blame support
  • Update preview image in README

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

janfaracik and others added 4 commits February 26, 2026 14:16
Not exactly sure how I hit it but was getting a massive stacktrace with a nullpointer
@timja
Copy link
Copy Markdown
Member

timja commented Feb 26, 2026

The build failure analyzer doesn't look amazing, did it look like this before?
image

@timja
Copy link
Copy Markdown
Member

timja commented Feb 26, 2026

I assume the reason themes aren't working is this line?
https://github.com/jenkinsci/theme-manager-plugin/blob/71a0ddc3732259908c096b897d611b9a5cb28fa8/src/main/java/io/jenkins/plugins/thememanager/ThemeManagerPageDecorator.java#L175

Should be safe to remove?

@timja
Copy link
Copy Markdown
Member

timja commented Mar 13, 2026

Before:
image

After:
image

@janfaracik
Copy link
Copy Markdown
Member Author

janfaracik commented Mar 14, 2026

What are your thoughts @timja? There's a few issues but nothing major right now, definitely needs some iteration but would be good to get it out into the wild

Copy link
Copy Markdown
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s some minor things left but they can be small follow ups

@janfaracik janfaracik merged commit 05626a8 into jenkinsci:master Mar 14, 2026
16 checks passed
@janfaracik janfaracik deleted the move-to-react branch March 14, 2026 12:50
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>17</source>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't hard code the java version. The required java version is set by the parent pom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

7 participants