Skip to content

Remove idealNames workaround#479

Merged
jglick merged 1 commit intojenkinsci:masterfrom
basil:ideal
Sep 5, 2025
Merged

Remove idealNames workaround#479
jglick merged 1 commit intojenkinsci:masterfrom
basil:ideal

Conversation

@basil
Copy link
Member

@basil basil commented Apr 4, 2025

As described in jenkinsci/branch-api-plugin#506, this workaround is no longer necessary. This PR cleans up after jenkinsci/branch-api-plugin#506 and cannot be merged until jenkinsci/branch-api-plugin#506 is merged, released, and adopted.

* {@link Trace#close()} the trace after the item is created.
*/
@NonNull
public static Trace beforeCreateItem(@NonNull AbstractFolder<?> project,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@basil basil changed the title Check to see if idealNames workaround can be removed Remove idealNames workaround Apr 8, 2025
@basil basil marked this pull request as ready for review July 7, 2025 23:55
@basil basil requested a review from a team as a code owner July 7, 2025 23:55
@basil basil requested a review from alecharp July 8, 2025 00:16
@jglick
Copy link
Member

jglick commented Jul 9, 2025

Should be given a couple weeks before merging I suppose.

@basil
Copy link
Member Author

basil commented Sep 4, 2025

@jglick Is it time?

@jglick jglick merged commit 8ae6330 into jenkinsci:master Sep 5, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants