Merged
Conversation
jglick
reviewed
Apr 8, 2025
| * {@link Trace#close()} the trace after the item is created. | ||
| */ | ||
| @NonNull | ||
| public static Trace beforeCreateItem(@NonNull AbstractFolder<?> project, |
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
would need to be
idealNames workaround can be removedidealNames workaround
Member
|
Should be given a couple weeks before merging I suppose. |
Member
Author
|
@jglick Is it time? |
jglick
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in jenkinsci/branch-api-plugin#506, this workaround is no longer necessary. This PR cleans up after jenkinsci/branch-api-plugin#506 and cannot be merged until jenkinsci/branch-api-plugin#506 is merged, released, and adopted.