remove usages of commons-lang from core#500
Merged
jglick merged 4 commits intojenkinsci:masterfrom May 28, 2025
Merged
Conversation
mawinter69
changed the title
jglick
reviewed
May 27, 2025
src/main/java/com/cloudbees/hudson/plugins/folder/ChildNameGenerator.java
Outdated
Show resolved
Hide resolved
jglick
reviewed
May 27, 2025
jglick
reviewed
May 28, 2025
src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorTest.java
Outdated
Show resolved
Hide resolved
jglick
approved these changes
May 28, 2025
szjozsef
reviewed
May 29, 2025
| } else if (interval.endsWith("ms")) { | ||
| units = TimeUnit.SECONDS; | ||
| interval = StringUtils.removeEnd(interval, "ms"); | ||
| interval = interval.substring(0, interval.length() - 1); |
There was a problem hiding this comment.
Here should not be: interval = interval.substring(0, interval.length() - 2); ?
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to remove commons-lang from core all direct and indirect usages must be replaced with commons-lang3 or native Java
Proposed changelog entries
Submitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)