Skip to content

Inadequate error reporting from ChildLoader #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jglick merged 2 commits into from
Nov 5, 2025
Merged

Inadequate error reporting from ChildLoader #548

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
168f682
Better error reporting from `ChildLoader`
jglick Nov 5, 2025
bc0b42f
Refined fix that does not fully revert #475
jglick Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/com/cloudbees/hudson/plugins/folder/ChildLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,12 @@
item.onLoad(parent, name);
return item;
} catch (Exception e) {
LOGGER.warning(() -> "could not load " + subdir + " due to " + e);
LOGGER.log(Level.FINE, null, e);
if (e instanceof FileNotFoundException && !LOGGER.isLoggable(Level.FINE)) {
// commonplace error from missing config.xml, avoid log spam unless FINE is enabled anyway
LOGGER.warning(() -> "could not load " + subdir + " due to " + e);
} else {
LOGGER.log(Level.WARNING, "could not load " + subdir, e);

Check warning on line 98 in src/main/java/com/cloudbees/hudson/plugins/folder/ChildLoader.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered lines 

Lines 94-98 are not covered by tests
}
return null;
}
}
Expand Down