Modernize plugin #204
Merged
Modernize plugin #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should not impact anything, other than improving the plugin health score.
Also requires minimim of Java 17
alecharp
requested review from
PierreBtz,
aheritier and
kwhetstone
as code owners
alecharp
force-pushed
the
chore/update-plugin-configuration
branch
from
1cbbbd2 to
d8dfbf3
Compare
Member
Author
|
As I updated the Jenkinsfile, a maintainer of the repository needs to open a pull request from the branch so that the build instructions are used. As I don't have write permission on the repository, the build instructions are coming from the main branch. |
This was referenced Jan 16, 2025
Merged
PierreBtz
approved these changes
Jan 16, 2025
Contributor
PierreBtz
left a comment
PierreBtz
left a comment
There was a problem hiding this comment.
lgtm, thanks for your contribution :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated the plugin to require Jenkins 2.479.3 and Java 17 at minimum. Used this to also migrate to Jakarta where javax was used.
Work based on #203.
Closes #203.
Closes #189.
Closes #178.
Closes #174.
Closes #167.
Testing done
Ran
mvn verifylocally with Java 17 and 21 with no problem.Submitter checklist