Skip to content

JENKINS-75933 Allow to control logging of masking message #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vrenjith wants to merge 5 commits into
base: master
Choose a base branch
from
Open

JENKINS-75933 Allow to control logging of masking message #379

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8815a13
Allow to control logging of masking message
vrenjith Jul 25, 2025
31c1832
Update BindingStep.java
vrenjith Jul 25, 2025
c9363c2
Update BindingStep.java
vrenjith Jul 25, 2025
62c3201
Update BindingStep.java
vrenjith Jul 25, 2025
3360478
Update BindingStep.java
vrenjith Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@
private static final class Execution2 extends GeneralNonBlockingStepExecution {

private static final long serialVersionUID = 1;
private static final boolean disableSecurityLogging = "false".equalsIgnoreCase(System.getenv("DISABLE_SECURITY_LOGGING"));
Copy link
Member

@jglick jglick Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://javadoc.jenkins.io/jenkins/util/SystemProperties.html#getBoolean(java.lang.String,boolean) and please use positive rather than negative sense, e.g. enable mask logging on by default or set to false to override.

Copy link
Author

@vrenjith vrenjith Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay @jglick
Let me change that.

Copy link
Author

@vrenjith vrenjith Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as per review comments @jglick


private transient BindingStep step;

Expand Down Expand Up @@ -137,9 +138,11 @@
}
if (!secretOverrides.isEmpty()) {
boolean unix = launcher == null || launcher.isUnix();
listener.getLogger().println("Masking supported pattern matches of " + secretOverrides.keySet().stream().map(
v -> unix ? "$" + v : "%" + v + "%"
).collect(Collectors.joining(" or ")));
if (!disableSecurityLogging) {

Check warning on line 141 in src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 141 is only partially covered, one branch is missing
listener.getLogger().println("Masking supported pattern matches of " + secretOverrides.keySet().stream().map(
v -> unix ? "$" + v : "%" + v + "%"
).collect(Collectors.joining(" or ")));
}
}

getContext().newBodyInvoker().
Expand Down