Skip to content

Remove unnecessary margins between controls #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
janfaracik wants to merge 2 commits into from
Closed

Remove unnecessary margins between controls #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cd66df
Remove unnecessary margins
janfaracik Dec 26, 2025
93a5714
Merge branch 'master' into remove-margins
janfaracik Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s/com/cloudbees/plugins/credentials/CredentialsProviderManager/Configuration/config.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form" xmlns:l="/lib/layout" xmlns:st="jelly:stapler">
<f:dropdownDescriptorSelector field="providerFilter" title="${%Providers}"/>
<f:dropdownDescriptorSelector field="typeFilter" title="${%Types}"/>
<f:entry title="${%Restrictions}">
<f:entry title="${%Restrictions}" class="jenkins-!-margin-0">
<f:repeatableHeteroProperty field="restrictions" hasHeader="true"/>
</f:entry>
</j:jelly>
3 changes: 2 additions & 1 deletion ...es/com/cloudbees/plugins/credentials/CredentialsStoreAction/DomainWrapper/configure.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@
<f:entry title="${%Description}" help="/plugin/credentials/help/domain/description.html">
<f:textarea field="description"/>
</f:entry>
<f:entry title="${%Specification}" help="/plugin/credentials/help/domain/specification.html">
<f:entry title="${%Specification}" help="/plugin/credentials/help/domain/specification.html"
class="jenkins-!-margin-0">
<f:hetero-list name="specifications" hasHeader="true" descriptors="${it.parent.specificationDescriptors}"
items="${instance.specifications}"/>
</f:entry>
Expand Down
3 changes: 2 additions & 1 deletion src/main/resources/com/cloudbees/plugins/credentials/CredentialsStoreAction/newDomain.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
<f:entry title="${%Description}" help="/plugin/credentials/help/domain/description.html">
<f:textarea name="description"/>
</f:entry>
<f:entry title="${%Specification}" help="/plugin/credentials/help/domain/specification.html">
<f:entry title="${%Specification}" help="/plugin/credentials/help/domain/specification.html"
Copy link
Member

@timja timja Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be handled in core? seems strange as its just consecutive entries?

class="jenkins-!-margin-0">
<f:hetero-list name="specifications" hasHeader="true" descriptors="${it.specificationDescriptors}"
items="${null}"/>
</f:entry>
Expand Down
Loading