Updated node and npm to the latest versions and fixed deprecation warnings after sass update#401
Merged
janfaracik merged 1 commit intojenkinsci:masterfrom Mar 15, 2025
Merged
Conversation
…nings after sass update
Member
|
Looks good to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated

nodeandnpmto the latest versions and fixed deprecation warnings after sass update. I also ran annpm audit fix.I saw these warnings also in the mainline and thought about updating and fixing these:
It was complaining about mixed-decls, and I followed the instructions how to fix it.
I am not sure if it is the right way and time for such a change, maybe @janfaracik or @mawinter69 have a better understanding.
Testing done
I ran mvn package and did not see any errors,
hpi:runalso worked and everything appeared to look the sameSubmitter checklist