Skip to content

Updated node and npm to the latest versions and fixed deprecation warnings after sass update#401

Merged
janfaracik merged 1 commit intojenkinsci:masterfrom
StefanSpieker:update
Mar 15, 2025
Merged

Updated node and npm to the latest versions and fixed deprecation warnings after sass update#401
janfaracik merged 1 commit intojenkinsci:masterfrom
StefanSpieker:update

Conversation

@StefanSpieker
Copy link
Copy Markdown
Contributor

Updated node and npm to the latest versions and fixed deprecation warnings after sass update. I also ran an npm audit fix.
I saw these warnings also in the mainline and thought about updating and fixing these:
grafik
It was complaining about mixed-decls, and I followed the instructions how to fix it.
I am not sure if it is the right way and time for such a change, maybe @janfaracik or @mawinter69 have a better understanding.

Testing done

I ran mvn package and did not see any errors, hpi:run also worked and everything appeared to look the same

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@StefanSpieker StefanSpieker requested a review from a team as a code owner March 15, 2025 09:45
@janfaracik
Copy link
Copy Markdown
Member

Looks good to me, thanks!

@janfaracik janfaracik merged commit daf52d8 into jenkinsci:master Mar 15, 2025
17 checks passed
@StefanSpieker StefanSpieker deleted the update branch March 15, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants